Repository navigation
Input help marker: an ⓘ after the label of each described input (Tools #147) - #45
Merged
Merged
Conversation
…s #147) The input's description is its help. Hovering the ⓘ (or the label) shows it, a click on the ⓘ keeps it open until a click elsewhere or Escape, and moving into the input with the keyboard (Tab) shows it under the input; a mouse click into the input does not. Inputs without a description (none, or only spaces) get no ⓘ. The code is a new part, LcHelp.groovy; the form calls it for each row. New GUI test body gui_test_help_body.groovy (interactions and runs apps). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tab into the Threshold spinner gave no help on CI: a Spinner hands its focus to its text field and takes it back, which clears JavaFX's focusVisible. A key filter on the window now notes each Tab, and focus gained within 0.5 s of it counts as keyboard focus too. The test checks the help, not focusVisible. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of CellMigrationLab/LabConstrictor-Tools#147: this is the QuPath step (Tools spec: Tools #151; napari: CellMigrationLab/LabConstrictor-napari#81, merged; Fiji follows).
What changes for the person using the form
focusVisible, so a mouse click into the input shows nothing extra).Files
LcHelp.groovy(new part, listed inparts.txt): the marker, the kept-open popup, the keyboard-focus tooltip.LabConstrictorTools.groovy:addRowscallsLcHelp.markfor each row (replacing the old label-only tooltip); ahelpMarkersmap, cleared with the form.tests/gui_test_help_body.groovy(new) + its apps intests/run_gui_ci.sh: markers and hover text on Find bright spots, a click keeps it open, Tab through the form shows each input's help, programmatic (mouse-like) focus does not, folded group and ChoicesFrom (Show a shape), no marker on Delayed points (runs app, no descriptions), blank description = none.README.md: one bullet.Checked locally (Windows 11)
parts.txtorder) plus the new test body compiles with QuPath 0.7.0's own Groovy 5.0.4 (FileSystemCompiler, against QuPath's jars)..groovylintrc.json,--failon info: 0 findings.After this merges, the QuPath column of the Input help marker row in Tools
docs/HOST_FEATURES.mdcan move from "planned" to done.🤖 Generated with Claude Code