Repository navigation
Honour the app-hosts discovery rule (feature app_hosts_v1) - #35
Merged
Merged
Conversation
…y qupath (app_hosts_v1) LcAppHosts ports app_hosts.listed_for(entry, 'qupath') with the same sentences; a skipped app is said in the Tools log and the dialog's skipped list, an absent declaration is logged every time. Require feature app_hosts_v1. Tests run the app_hosts vectors of conformance.json (fail when missing), the sandbox driver tests/gui_test_listing_body.groovy runs for the app matrix in the qupath-gui job. CI temporarily installs Tools from claude/app-hosts-discovery. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
… for it) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QuPath lists an app only if the registry entry's
hostssayqupath(Tools PR #133, merged; featureapp_hosts_v1).LcAppHosts.groovy(new part, in parts.txt): Groovy port ofapp_hosts.listed_for(entry, 'qupath'), same sentences. Applied inLcRegistry.loadFile, after the trust checks. Not listed: the skip sentence goes to the Tools log and is the problem text in the dialog's "skipped" list (same place as the Tools-too-old sentence). Nohostskey: listed, and the 'declares no hosts' sentence is logged every time the registry is read. Invalid declaration: not listed, sentence with the problem.LcCompat.REQUIRED_FEATURESnow includesapp_hosts_v1(min_tools_version stays 0.3.0a1). Existing tests that fabricate schemas got the feature added; new trust case for an app lacking onlyapp_hosts_v1.tests/gui_test_app_hosts_body.groovy: runs theapp_hostssection of conformance.json (cases, sentence templates, compat_rule, compat_cases) and FAILS if the key is missing; also writes the qupath vectors as real registry files and checksLcRegistry.load(),problemsand the log.gui_test_conformance_bodyalso requires theapp_hostssection.tests/gui_test_listing_body.groovy(contract of Toolstests/release_sandbox/README.md: env LC_HOME, LC_EXPECT_APP, LC_EXPECT_LISTED, LC_EXPECT_SENTENCE; prints exactly oneCHECK qupath_lists_the_app/CHECK qupath_does_not_list_the_appline).tests/run_gui_ci.shaccepts it by name (not in the default run);tests/run_listing_matrix.shruns it in the qupath-gui job for the matrix: Playground, NucleiSky, GuessTheCondition listed; VLab4Mic and CellTracksColab NOT listed; an app with no declaration listed.CI installs Tools from
main(TOOLS_REF, as before; the temporary pointer at the Tools branch is removed now that #133 is merged).release.ymlalso installs Toolsmainfor its OS smoke; at release time it needs a Tools withapp_hosts_v1(main has it).Known limit (same as the Tools-too-old sentence): with at least one app left, the dialog shows the skipped list after "Rescan apps", not at first open.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN