Repository navigation
Allow adding basic lands while sideboarding in limited games - #12182
Open
DandamanAUS wants to merge 1 commit into
Open
DandamanAUS wants to merge 1 commit into
DandamanAUS wants to merge 1 commit into
Conversation
…rge#9087) The mobile sideboard dialog only let cards move between the main deck and sideboard, so draft/sealed players (Adventure inn events, Quest drafts, etc.) couldn't add basic lands between games. When the match uses the Limited deck format, show a "..." button in the top-right corner of the match menu bar (shrinking the tabs to make room) with an "Add Basic Lands" item, matching where the option sits in the deck editor. It opens the existing AddBasicLandsDialog and adds the lands to the main deck. If the menu bar is rotated to the side, the dialog shows the deck editor header with the same "..." menu instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9087.
In the mobile/Adventure GUI, the between-games sideboard dialog only allowed moving cards between the main deck and sideboard, so draft/sealed players (Adventure inn events, Quest drafts) had no way to add basic lands, which limited rules treat as freely available.
Changes
DeckFormat.Limited,FSideboardDialogshows a "..." button in the top-right corner of the match menu bar, with an "Add Basic Lands" item (land icon), the same place and look as in the deck editor. It opens the existingAddBasicLandsDialog(land set fromDeckProxy.getDefaultLandSet) and adds the chosen lands to the main deck tab.FMenuBar.setTrailingWidthreserves room at the right of the bar so the Game/Players/Log/Stack tabs shrink to fit the button while the dialog is open; the space is released when it closes.FDeckEditor.DeckHeaderwith the same "..." menu instead.MatchController.sideboardpasses whether the current game type is Limited.Constructed and Quest (non-draft) sideboarding is unchanged.
Matchalready accepts the returned main deck as is, so no game-logic changes were needed.Testing
Built
forge-gui-mobile-devand played an Adventure inn draft on Windows: after game 1, the "..." menu appears top-right on the sideboard screen, and basics added there are in the deck for the next game.This change was written with Claude Code (co-author on the commit).
🤖 Generated with Claude Code