Skip to content

Adventure: translate enemies, points of interest and town names through Localizer - #12166

Open
churrufli wants to merge 1 commit into
Card-Forge:masterfrom
churrufli:adventure-translations-3
Open

churrufli wants to merge 1 commit into
Card-Forge:masterfrom
churrufli:adventure-translations-3

Conversation

@churrufli

@churrufli churrufli commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Adventure Mode: Localize enemies, POIs and town names

Translations in adventure-<lang>.properties with English fallback.

What it does

  • EnemyData, EnemySprite, and PointOfInterest now have getDisplayName() for localization
  • Town names drawn from town_names_*.txt are now translatable
  • Six UI labels moved to tr() (Back, Detail, Status, Mythic...)
  • Spanish translations for Shandalar: 460 enemies, 11 boss intros/insults, 117 POIs, 2,234 town names

Fixes

  • Fixed Config.getFile substituting ui/quests.json with languages/quests-es-ES.json, which broke landscape quest log
  • Restored missing lblAdventure label in es-ES.properties

Why it's safe

  • English unchanged; apostrophes and special chars preserved
  • All lookups still use English names (win/loss records, deck selection)
  • Saves compatible; no field changes
  • No hot paths affected; name computed once per screen
  • All translation keys exist with no duplicates
  • Only affects Adventure Mode code

Testing

  • Built and started Adventure Mode in Spanish
  • Quest log opens in landscape
  • Loaded existing save: towns, enemies, stats show translated names
  • Saved and reloaded
  • Switched to English: names revert correctly

I researched and designed the approach; Claude Code handled the implementation and bulk translation into my native language

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Adventure For the Adventure Module

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant