Skip to content

Removed file provider workaround to fix security issue - #659

Merged
vanniktech merged 5 commits into
CanHub:mainfrom
M66B:main
Jan 7, 2025
Merged

vanniktech merged 5 commits into
CanHub:mainfrom
M66B:main

Conversation

@M66B

@M66B M66B commented Jan 7, 2025

Copy link
Copy Markdown
Contributor

Refs #644

@vanniktech

Copy link
Copy Markdown
Contributor

Could you run ktlintFormat such that the build gets green?

@M66B

M66B commented Jan 7, 2025

Copy link
Copy Markdown
Contributor Author

I'll finish a fix for my own project, and update the pull request. An import will need to be removed to pass lint.

@M66B

M66B commented Jan 7, 2025

Copy link
Copy Markdown
Contributor Author

The pull request has been updated

@M66B

M66B commented Jan 7, 2025

Copy link
Copy Markdown
Contributor Author

Just for the record: the indentation was already 1 space. Anyway, this should be fixed too now.

@M66B

M66B commented Jan 7, 2025

Copy link
Copy Markdown
Contributor Author

Please try again. This was caused by my inexperience with Kotlin.

@vanniktech
vanniktech merged commit fc3d4e7 into CanHub:main Jan 7, 2025
@vanniktech

Copy link
Copy Markdown
Contributor

No worries and thank you very much for fixing this issue!

@M66B

M66B commented Jan 7, 2025

Copy link
Copy Markdown
Contributor Author

You're very welcome.

Thank your for providing this useful library. I'm using it in FairEmail to let people edit images inserted into a message.

I think the related issue can be closed too now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants