Skip to content

README: Slightly improve the Migration section. #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vanniktech merged 1 commit into from
Oct 30, 2022
Merged

README: Slightly improve the Migration section. #520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,13 @@ override fun showImageSourceDialog(openSource: (Source) -> Unit) {

## Migrating from Android Image Cropper

Add this library like it's shown above.
Start by using [Version 4.3.3](https://github.com/CanHub/Android-Image-Cropper/releases/tag/4.3.3):

```groovy
dependencies {
implementation("com.vanniktech:android-image-cropper:4.3.3")
}
```

### Update all imports

Expand All @@ -146,14 +152,16 @@ Add this library like it's shown above.
+import com.canhub.cropper.CropImageActivity
```

# Update all XML references
### Update all XML references

```diff
-<com.theartofdev.edmodo.cropper.CropImageView
+<com.canhub.cropper.CropImageView
```

Consult with the sample app on how to use our Activity Contracts since `onActivityResult` got deprecated.
When using Activity Contracts, consult with the sample app on how to use our Activity Contracts since `onActivityResult` got deprecated.

Versions after 4.3.3 have changed the APIs quite a bit, it's best to upgrade to each minor version individually, remove deprecated API usages and continue upgrading. So after using 4.3.3, upgrade to 4.4.0, etc.

## License

Expand Down