Skip to content

API: Deprecate CropImageView.isSaveBitmapToInstanceState #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vanniktech merged 1 commit into from
Oct 30, 2022
Merged

API: Deprecate CropImageView.isSaveBitmapToInstanceState #518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cropper/src/main/kotlin/com/canhub/cropper/CropImageView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ class CropImageView @JvmOverloads constructor(
* If false the bitmap is not saved and if restore is required to view will be empty, storing the
* bitmap requires saving it to file which can be expensive. default: false.
*/
@Deprecated("This functionality is deprecated, please remove it altogether or create an issue and explain WHY you need this.")
var isSaveBitmapToInstanceState = false

/**
Expand Down Expand Up @@ -1082,7 +1083,7 @@ class CropImageView @JvmOverloads constructor(
}

val bundle = Bundle()
val loadedImageUri =
@Suppress("DEPRECATION") val loadedImageUri =
if (isSaveBitmapToInstanceState && imageUri == null && mImageResource < 1) {
BitmapUtils.writeTempStateStoreBitmap(
context = context,
Expand Down Expand Up @@ -1805,6 +1806,7 @@ class CropImageView @JvmOverloads constructor(
val a = context.obtainStyledAttributes(attrs, R.styleable.CropImageView, 0, 0)
val default = CropImageOptions()
try {
@Suppress("DEPRECATION")
isSaveBitmapToInstanceState = a.getBoolean(R.styleable.CropImageView_cropSaveBitmapToInstanceState, isSaveBitmapToInstanceState)

CropImageOptions(
Expand Down