Skip to content

Added intent chooser for selecting image sources - #326

Merged
Canato merged 18 commits into
CanHub:mainfrom
Devenom1:feature/325-add-intent-chooser-as-alternate-for-image-source
Apr 3, 2022
Merged

Canato merged 18 commits into
CanHub:mainfrom
Devenom1:feature/325-add-intent-chooser-as-alternate-for-image-source

Conversation

@Devenom1

@Devenom1 Devenom1 commented Mar 6, 2022 •

Copy link
Copy Markdown
Contributor

closes #325

Added Intent Chooser [New Feature]

Description:

This PR adds an option to show an intent chooser in place of an alert dialog. The part that triggers it is currently commented out. @Canato let me know what you think. I hope its good. I've left a screenshot below

image

@Devenom1
Devenom1 requested a review from a team as a code owner March 6, 2022 22:14

@Canato Canato left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Will keep the discussion on the issue related! So we can focus on code here.

Don't forget the Changelog update

Comment thread cropper/src/main/java/com/canhub/cropper/CropImageActivity.kt Outdated
@Canato

Canato commented Mar 7, 2022

Copy link
Copy Markdown
Member

branch need to be rebased for latest main

@Devenom1
Devenom1 requested a review from Canato March 8, 2022 23:11
Comment thread cropper/src/main/java/com/canhub/cropper/CropImageActivity.kt Outdated
Comment thread cropper/src/main/java/com/canhub/cropper/CropImageActivity.kt Outdated
Comment thread cropper/src/main/java/com/canhub/cropper/CropImageActivity.kt Outdated
Comment thread cropper/src/main/java/com/canhub/cropper/CropImageActivity.kt Outdated
Comment thread cropper/src/main/java/com/canhub/cropper/CropImageActivity.kt Outdated
Comment thread cropper/src/main/java/com/canhub/cropper/CropImageActivity.kt Outdated
Comment thread cropper/src/main/java/com/canhub/cropper/CropImageActivity.kt Outdated
Comment thread cropper/src/main/java/com/canhub/cropper/CropImageActivity.kt Outdated
Comment thread cropper/src/main/java/com/canhub/cropper/CropImageActivity.kt Outdated
Comment thread cropper/src/main/java/com/canhub/cropper/CropImageActivity.kt Outdated
@Canato

Canato commented Mar 14, 2022

Copy link
Copy Markdown
Member

On holidays until next week, them I'm back to this ticket ^^

Sorry for delay

@Devenom1

Copy link
Copy Markdown
Contributor Author

On holidays until next week, them I'm back to this ticket ^^

Sorry for delay

No Problem. Enjoy @Canato 🎉🎉🎊

@Devenom1
Devenom1 requested a review from Canato March 24, 2022 12:38
@Devenom1

Copy link
Copy Markdown
Contributor Author

Can you recheck @Canato I've added all the suggested changes possible

@Canato Canato left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements, some more bits to polish

Comment thread cropper/src/main/java/com/canhub/cropper/CropImageActivity.kt Outdated
Comment thread cropper/src/main/java/com/canhub/cropper/CropImageActivity.kt Outdated
Comment thread cropper/src/main/java/com/canhub/cropper/CropImageActivity.kt Outdated
Comment thread cropper/src/main/java/com/canhub/cropper/CropImageActivity.kt Outdated
Comment thread cropper/src/main/java/com/canhub/cropper/CropImageIntentChooser.kt Outdated
Comment thread cropper/src/main/java/com/canhub/cropper/CropImageIntentChooser.kt Outdated
Comment thread cropper/src/main/java/com/canhub/cropper/CropImageIntentChooser.kt Outdated
Comment thread cropper/src/main/java/com/canhub/cropper/CropImageIntentChooser.kt
Comment thread cropper/src/main/java/com/canhub/cropper/CropImageIntentChooser.kt Outdated
@Devenom1
Devenom1 requested a review from Canato March 30, 2022 22:15
@Devenom1

Copy link
Copy Markdown
Contributor Author

All changes done

@Canato Canato left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is almost done! thanks for this work =D

don't forget to rebase with the latest changes

Comment thread cropper/src/main/java/com/canhub/cropper/CropImageIntentChooser.kt Outdated
Comment thread cropper/src/main/java/com/canhub/cropper/CropImageActivity.kt Outdated
Comment thread cropper/src/main/java/com/canhub/cropper/CropImageActivity.kt Outdated
Comment thread cropper/src/main/java/com/canhub/cropper/CropImageActivity.kt Outdated

@Canato Canato left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! we release Tomorrow or Tuesday ^^

Congratulations 🎉

@Canato
Canato merged commit 657a9af into CanHub:main Apr 3, 2022
@Devenom1

Devenom1 commented Apr 4, 2022

Copy link
Copy Markdown
Contributor Author

Amazing work! we release Tomorrow or Tuesday ^^

Congratulations 🎉

Thanks @Canato This is my first ever contribution. Technically 2nd cz of the other minor PR but 🥳🥳🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat] - Add an Intent Chooser as an alternate to current Alert Dialog to choose image source

2 participants