Skip to content

fix: 릴리즈 리뷰 반영 (계약 설명 3건 정정) - #292

Merged
chanwoo7 merged 1 commit into
developfrom
fix/release-review-contract-wording
Sep 9, 2026
Merged

fix: 릴리즈 리뷰 반영 (계약 설명 3건 정정)#292
chanwoo7 merged 1 commit into
developfrom
fix/release-review-contract-wording

Conversation

@chanwoo7

@chanwoo7 chanwoo7 commented Sep 9, 2026

Copy link
Copy Markdown
Member

릴리즈 PR #289 리뷰 추가분. 동작은 바꾸지 않고 설명만 실제 계약에 맞춘다.

셋 다 원인이 같다 — 코드의 일부만 보고 적었다.

대상 적었던 것 실제
sellerConversationUpdated 활성 매장 보유자만 구독 activeWhere{ deleted_at: null }뿐. is_active를 포함하는 건 visibleWhere (prisma/active-where.ts:15,18) → 비활성 매장도 구독 열림
SellerProductListInput.search 상품명 부분일치 OR로 상품명 + 태그명을 함께 본다 (product.repository.ts:145-157)
SellerAuditLog.storeId 비밀번호 변경 등이면 null store?.id를 넣어 매장 보유 판매자면 채워진다 (seller-credential.service.ts:205)

첫 건에서 코드가 아니라 설명을 고친 이유

is_active를 조건에 넣는 선택지도 있었지만, 매장을 비활성으로 돌려도 진행 중인 고객 문의는 계속 받아야 한다. 노출만 잠시 끈 사이 메시지를 놓치는 쪽이 더 나쁘다. 지금 동작이 맞고 내 설명이 틀렸다.

검증

전체 225 suites 1,874건 통과. tsc·docs:check 통과.

전부 코드의 일부만 보고 적어 실제 계약과 어긋난 설명이다. 동작은 바꾸지 않는다.

- sellerConversationUpdated — "활성 매장"이라 적었으나 findStoreBySellerAccount는
  activeWhere({ deleted_at: null })만 쓴다. is_active를 포함하는 건 visibleWhere다
  (prisma/active-where.ts:15,18). 비활성 매장도 구독이 열린다.
  코드가 아니라 설명을 고친 이유: 매장을 비활성으로 돌려도 진행 중인 고객 문의는
  계속 받아야 한다. is_active를 넣으면 노출만 잠시 끈 사이 메시지를 놓친다.
- SellerProductListInput.search — "상품명 부분일치"만 적었으나 OR로 상품명과
  product_tags.tag.name을 함께 본다 (product.repository.ts:145-157)
- SellerAuditLog.storeId — "비밀번호 변경 등이면 null"이라 적었으나
  seller-credential.service.ts:205가 store?.id를 넣어, 매장을 가진 판매자의
  비밀번호 변경 로그는 storeId가 채워진다. 이 로그를 잘못 분류하게 만드는 설명이었다

전체 1,874건 통과.
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 74d3e3d0-e0a8-4f62-8420-62bc22bd782e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

🧹 knip — dead-code 리포트

Unused dependencies (1)
Duplicate exports (1)
전체 리포트
Unused dependencies (1)
graphql-ws  package.json:65:6
Duplicate exports (1)
KEYWORD_RANK_SNAPSHOT_SIZE|MAX_POPULAR_KEYWORDS_LIMIT  src/features/search/constants/search.constants.ts

청소 후보(오탐 가능) · 기준 docs/guide/architecture-conventions.md

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

🩺 NestJS Doctor — 90/100 (Excellent)

진단 313건 (error 0).

Category error warning info
architecture 0 0 9
correctness 0 161 0
performance 0 27 17
schema 0 0 86
security 0 13 0
architecture / security 상위 항목
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'IAuditLogRepository'.
  • warning security/security/no-exposed-env-vars: Direct 'process.env.NODE_ENV' access in 'AuthController'. Use ConfigService instead.
  • warning security/security/require-guards-on-endpoints: Endpoint 'start' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'callback' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'refresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'logout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogin' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerRefresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'devIssueToken' has no @UseGuards() at class or method level.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/conversation/repositories/conversation.repository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'ConversationRepository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/order/repositories/order.repository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'OrderRepository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/product/repositories/product.repository'.

오탐 포함 가능 · 기준 docs/guide/architecture-conventions.md

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 97.62% 5915/6059
🟢 Branches 93.15% 2324/2495
🟢 Functions 96.47% 1176/1219
🟢 Lines 98.2% 5388/5487

Test suite run success

1874 tests passing in 225 suites.

Report generated by 🧪jest coverage report action from 2659a4d

@chanwoo7
chanwoo7 merged commit 9406df6 into develop Sep 9, 2026
11 checks passed
@chanwoo7
chanwoo7 deleted the fix/release-review-contract-wording branch September 9, 2026 21:24
@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant