Skip to content

Registry org create/update carries too many responsibilities #1925

Description

@david-rocca

Evidence:

  • src/repositories/baseOrgRepository.js:615-982 handles registry/legacy conversion, UUID generation, role discriminator selection, review object creation, audit creation, legacy write, filtering, and output shape.
  • The same file has comments indicating known fragility around legacy write behavior at src/repositories/baseOrgRepository.js:750-754.

Impact:

  • Hard to change one responsibility without affecting the others.
  • Audit behavior is duplicated between inline code and helper functions.
  • Role/discriminator changes are especially risky because delete/recreate behavior is embedded in the update path.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions