Skip to content

Deployment environment names drift between Docker, npm scripts, and config #1919

Description

@david-rocca

Evidence:

  • docker/entrypoint.sh:13-18 branches on prod-staging, adp-test, and production.
  • package.json:101-103 maps start:prdstg, start:prd, and start:adptest to NODE_ENV=production.
  • docker/default.json-docker:26-39 defines prod-staging and adp-test, but those values are bypassed when the npm scripts force NODE_ENV=production.
  • src/scripts/updateOpenapiHost.js:27-32 only has a production branch for those starts.

Impact:

  • The effective deployment config is not obvious from the container's incoming NODE_ENV.
  • prod-staging and adp-test look configurable but are not used by the app after the npm script resets NODE_ENV.
  • This increases risk of using production database/API host settings in staging-like deployments.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions