Repository navigation
Conversation
Contributor
|
Thank you for the pull request. ScanRuler is dual-licensed (AGPL and commercial), which only works if its author may license every line of it, so a short Contributor License Agreement is needed once. You keep your copyright. To sign, reply with the sentence below exactly: I agree to CLA.md You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Owner
|
Would love to merge this: it's a clean fix with a good regression test. It needs the CLA signed once, just reply with I agree to CLA.md If it isn't signed by November 16, I'll close this and fix the banding on my side. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fitting a plane to a flat scan can produce alternating dark bands because the translucent preview occupies the same depth as the scan. Apply the same polygon depth offset already used for committed shells to filled previews. Fitted vertices and depth testing remain unchanged.
Added a standalone browser regression that imports a generated 3,072-triangle block through the normal file input and fits its face. On current upstream main, the interior pixel colour range was 63 before the fix and 0 after it, with the same geometry, camera and assertion. No dependencies added.
Validation: isolated upstream-based branch passed plugin-boundary and units checks, production build and the new browser regression. The integration branch also passed the full gate: 3,115 unit tests, 123 MCP tests, build and all available browser suites. Private scan fixtures were unavailable; browser validation used headless Chrome.
Run the regression against a running app with
APP_URL=http://localhost:5173 node scripts/e2e-preview-surface.mjs(setCHROMEif needed).