Repository navigation
Conversation
Contributor
|
All contributors have signed the CLA. Thank you. |
Contributor
Author
|
I agree to CLA.md |
A stored member comes out as large as its stored bytes whatever size it declares, so the limit now takes the larger of the two. Only the members read count towards the total, and the per-member cap is raised to 512 MB: 256 MB turned away 3MF scans of a few million triangles that opened before.
60 of 65 tasks
Contributor
Author
|
Closing: the 3MF archive size limits landed in 0.9.6 (https://github.com/CNCKitchen/ScanRuler/releases/tag/v0.9.6). Thanks for taking it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bound 3MF archive expansion before fflate allocates entry contents.
Why
Compressed 3MF files can declare very large expanded entries or excessive member counts. Parsing such input without limits can exhaust browser memory.
Changes
Verification
Risk
Ordinary 3MF files are unaffected. Files beyond supported limits now fail with a specific error.