Repository navigation
Conversation
Contributor
|
Thank you for the pull request. ScanRuler is dual-licensed (AGPL and commercial), which only works if its author may license every line of it, so a short Contributor License Agreement is needed once. You keep your copyright. To sign, reply with the sentence below exactly: I agree to CLA.md You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Greg-J
marked this pull request as ready for review
October 31, 2026 21:21
This was referenced Oct 31, 2026
Author
|
I agree to CLA.md
… Message ID: ***@***.***>
|
Owner
|
Thank you, Greg-J. Both of these are fixed in 0.10.0. The CLA isn't signed on this PR, so I couldn't merge it and wrote the fixes separately; the changelog credits you for both.
Closing this as done. If you sign the CLA, I'd be glad to take your other open PRs as they are. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two import edge cases can change the result despite equivalent coordinates or the user's focused control:
+0and-0as different vertices. Two triangles sharing an origin produced five vertices instead of four when one origin used negative zero. Canonicalize zero in both the hash and stored comparison key, without changing the input or merging distinct nonzero coordinates.Adds five welding regression cases and real-keyboard browser checks for Cancel, choosing inches, and Open. The new regressions were run against the original code and failed before the fixes.
Validation:
e2e-mesh-editsande2e-reverse-body-tree. In the former, the shared field setter enters9.995when asked to replace9.999with5. These pre-existing failures are outside this patch.No new dependencies.