Repository navigation
Remember Save As locations independently for projects and exports - #136
Open
Myuavbug66 wants to merge 4 commits into
Open
Myuavbug66 wants to merge 4 commits into
Myuavbug66 wants to merge 4 commits into
Conversation
Add padded revision suggestions, optional local Windows Save As, separate remembered project/export destinations and write-completion handling. Include focused unit/native/browser coverage and usage documentation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace local-server and PowerShell output integration with independent browser project/export folder handles and Settings controls. Preserve numbered saves, expose permission/cancellation failures and cover static production behavior without a local writer. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Sorry I really messed this one up I'm going back and fixing it or trying to try to do too much at once SH now I'm separating it out into different branches. And I posted things that work on my locally hosted test app that apparently will not work on the web hosted app. So I'm looking at fixing it and resubmitting it. Two separate branches. |
Remove fixed folder settings and automatic revisions from the location contribution. Select file targets before generation and wait for writes to finish. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Capture Save As picker writes in the unit and trimmed-mesh browser tests so they validate exported bytes instead of waiting for downloads. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save where you are working
Save and export should let you change folders in the normal Save As dialog and
stay there while you work, rather than repeatedly moving files out of Downloads.
This location-only change uses separate browser history IDs for project saves
and exports. Navigate to a different folder in either dialog; the browser can
remember that choice without changing the other dialog's location.
Hosted ScanRuler support: works on the normal HTTPS website after merge and
deployment, in supporting desktop Chrome/Edge. No local development server,
installed helper or fixed-folder Settings are required. Other browsers keep
ordinary downloads, governed by their browser download settings.
Automatic revisions, including
-001, are excluded and are proposed separatelyin PR #137. The app suggests normal filenames; native Save As
handles overwrite confirmation.
Usage
Navigate elsewhere at any time; no Settings change is needed.
Project saves and exports have separate histories; all export formats share the
export history. Open-dialog behavior is unchanged.
Implementation, compatibility and validation
showSaveFilePickerwith stablescanruler-projectsandscanruler-exportsIDs, without forcing astartIndirectory.browser still has the button click's user activation.
engineer STEP/meshes and edited/reduced/trimmed mesh exports. STL in inches
still uses the
.stlextension.saved. Cancellation, permission errors and write failures are explicit, not
silent download fallbacks.
app cannot obtain arbitrary full disk paths or guarantee permanent history.
Local validation:
production exports (11), CAD/edited exports (5), history (24), recovery (23),
imports (18) and CAD undo (9).
or local-writer requests; CI is wired to run it against production too.
Picker doubles verify options, user activation, cancellation and writes using
isolated test storage. They simulate directory memory; they do not certify
native OS history or overwrite-confirmation behavior. Those remain manual checks.
Full unit/MCP/end-to-end suites were not run locally for this correction.
The previous Settings/native-dialog/numbered-file screenshots do not describe
this design and should not be carried into this location-only PR.