Skip to content

Remember Save As locations independently for projects and exports - #136

Open
Myuavbug66 wants to merge 4 commits into
CNCKitchen:mainfrom
Myuavbug66:pr/project-save-export
Open

Myuavbug66 wants to merge 4 commits into
CNCKitchen:mainfrom
Myuavbug66:pr/project-save-export

Conversation

@Myuavbug66

@Myuavbug66 Myuavbug66 commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Save where you are working

Save and export should let you change folders in the normal Save As dialog and
stay there while you work, rather than repeatedly moving files out of Downloads.

This location-only change uses separate browser history IDs for project saves
and exports. Navigate to a different folder in either dialog; the browser can
remember that choice without changing the other dialog's location.

Hosted ScanRuler support: works on the normal HTTPS website after merge and
deployment, in supporting desktop Chrome/Edge. No local development server,
installed helper or fixed-folder Settings are required. Other browsers keep
ordinary downloads, governed by their browser download settings.

Automatic revisions, including -001, are excluded and are proposed separately
in PR #137.
The app suggests normal filenames; native Save As
handles overwrite confirmation.

Usage

  1. Click Save or an export button.
  2. Choose the filename and folder in Save As.
  3. Keep working. The next dialog uses the same browser-managed location history.
    Navigate elsewhere at any time; no Settings change is needed.

Project saves and exports have separate histories; all export formats share the
export history. Open-dialog behavior is unchanged.

Implementation, compatibility and validation
  • Uses showSaveFilePicker with stable scanruler-projects and
    scanruler-exports IDs, without forcing a startIn directory.
  • Selects the target before packing, lazy loading or CAD/mesh generation so the
    browser still has the button click's user activation.
  • Passes targets explicitly through export work; no global pending file target.
  • Covers measurement STEP, scan meshes/clouds, sheet CSV/SVG/DXF, Reverse
    engineer STEP/meshes and edited/reduced/trimmed mesh exports. STL in inches
    still uses the .stl extension.
  • Waits for file writes to close before reporting success or marking a project
    saved. Cancellation, permission errors and write failures are explicit, not
    silent download fallbacks.
  • Browser history is website/profile-specific and can be forgotten/reset. The
    app cannot obtain arbitrary full disk paths or guarantee permanent history.
  • No dependencies or local-server endpoints are added.

Local validation:

  • 48 focused unit tests passed (save targets, activity, projects and schema).
  • Production build, plugin boundary, display-unit and whitespace checks passed.
  • 109 browser assertions passed: static Save As locations (19), bundled
    production exports (11), CAD/edited exports (5), history (24), recovery (23),
    imports (18) and CAD undo (9).
  • The location check runs against static production assets with no source-module
    or local-writer requests; CI is wired to run it against production too.

Picker doubles verify options, user activation, cancellation and writes using
isolated test storage. They simulate directory memory; they do not certify
native OS history or overwrite-confirmation behavior. Those remain manual checks.
Full unit/MCP/end-to-end suites were not run locally for this correction.

The previous Settings/native-dialog/numbered-file screenshots do not describe
this design and should not be carried into this location-only PR.

Myuavbug66 and others added 2 commits November 10, 2026 16:11
Add padded revision suggestions, optional local Windows Save As, separate remembered project/export destinations and write-completion handling. Include focused unit/native/browser coverage and usage documentation.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace local-server and PowerShell output integration with independent browser project/export folder handles and Settings controls. Preserve numbered saves, expose permission/cancellation failures and cover static production behavior without a local writer.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Myuavbug66

Copy link
Copy Markdown
Contributor Author

Sorry I really messed this one up I'm going back and fixing it or trying to try to do too much at once SH now I'm separating it out into different branches. And I posted things that work on my locally hosted test app that apparently will not work on the web hosted app. So I'm looking at fixing it and resubmitting it. Two separate branches.

Remove fixed folder settings and automatic revisions from the location contribution. Select file targets before generation and wait for writes to finish.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Myuavbug66 Myuavbug66 changed the title Remember separate project/export folders and add numbered save revisions Remember Save As locations independently for projects and exports Nov 10, 2026
Capture Save As picker writes in the unit and trimmed-mesh browser tests so they validate exported bytes instead of waiting for downloads.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant