Repository navigation
Replace python dataclasses with pydantic dataclasses - #674
Merged
Merged
Conversation
* fix unit test * add some comments explaining why we're doing it this way also use with... syntax to reduce filehandler boilerplate
makes json roundtrip easier also prepares for FastAPI adoption # Conflicts: # src/ssvc/_mixins.py # src/ssvc/decision_points/cvss/base.py # src/ssvc_v2.py
…e_pydantic # Conflicts: # src/ssvc/outcomes/base.py
ahouseholder
commented
Jan 24, 2025
ahouseholder
commented
Jan 24, 2025
ahouseholder
commented
Jan 24, 2025
ahouseholder
left a comment
ahouseholder
left a comment
Contributor
Author
There was a problem hiding this comment.
This whole commit was just me regenerating the json files with the fixed scripts
sei-vsarvepalli
approved these changes
Jan 24, 2025
sei-vsarvepalli
left a comment
sei-vsarvepalli
left a comment
Contributor
There was a problem hiding this comment.
Pydantic it is now.
This was referenced Feb 19, 2025
This was referenced Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale:
dataclasses-json