Repository navigation
Add print-site plugin to restore all-in-one page feature - #338
Merged
Merged
Conversation
ahouseholder
added
enhancement
ahouseholder
requested review from
cgyarbrough and
sei-vsarvepalli
as code owners
October 9, 2023 15:02
sei-vsarvepalli
approved these changes
Oct 10, 2023
jeroenh
pushed a commit
to jeroenh/SSVC
that referenced
this pull request
Oct 18, 2023
* add mkdocs-print-site-plugin * fix errors reported by print-site plugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the mkdocs-print-site-plugin
https://pypi.org/project/mkdocs-print-site-plugin/
Which makes it possible to generate a single-page version of the site like
https://ahouseholder.github.io/SSVC/print_page/
We would need to do some clean up to make it look right, but I think that cleanup is premature at this stage. (If we include this now then decide to roll it back later, it is as simple as removing the
- print-siteline frommkdocs.yml.Also, if this is the way forward, then the following issues will be de facto resolved because it will eliminate our dependency on a custom doc build process.