Repository navigation
Replace Utility with Automatable in Deployer tree - #248
Merged
Merged
Conversation
v2 had 108 rows, v2_1 has 72 rows. This reflects the change from Utility having 3 options to Automatable only having 2. Utility = laborious implies Automatable = no Utility = super effective implies Automatable = yes Utility = efficient is ambiguous about the Automatable value. So all I did was eliminate the Utility = efficient rows from the CSV and kept the values for "laborious" and "super effective" It might be necessary to tune these somewhat but at least this version is 100% consistent with what information was already present in the v2 CSV file.
Note this effectively translates to - pruning out the "efficient" branch of Utility - renaming "Utility" to "Automatable" - renaming "laborious" to "no" - renaming "super effective" to "yes" I used overleaf to generate the pdf from the tex file.
Deployer tree JSON version with no Utility/Value Density. 103 nodes and 72 decisions.
The file was obsoleted by deployer-options_v2_1.csv
…x_238 * 'main' of https://github.com/CERTCC/SSVC: Updating text to conform to Human Impact change (#236) # Conflicts: # doc/md_src_files/060_decision-trees.md
ahouseholder
requested review from
cgyarbrough,
ehatleback,
j--- and
sei-vsarvepalli
June 16, 2023 20:20
sei-vsarvepalli
approved these changes
Jun 16, 2023
sei-vsarvepalli
left a comment
sei-vsarvepalli
left a comment
Contributor
There was a problem hiding this comment.
Looks correct for clean up and simplification of Deployer tree
Removing sync defer from D3 library to ensure init scripts do not fail.
sei-vsarvepalli
temporarily deployed
to
github-pages
June 16, 2023 22:02 — with 
GitHub Pages
Inactive
sei-vsarvepalli
temporarily deployed
to
github-pages
June 16, 2023 22:08 — with
GitHub Pages
Inactive
cgyarbrough
approved these changes
Jun 22, 2023
cgyarbrough
left a comment
cgyarbrough
left a comment
Contributor
There was a problem hiding this comment.
I agree with the changes submitted. Simplification is usually a good thing. We discussed these changes in our team meeting.
ahouseholder
added a commit
that referenced
this pull request
Jun 30, 2023
… feature/fix-246 * 'feature/fix-246' of https://github.com/CERTCC/SSVC: add subsubsection header for tree versioning Update link to SSVC_Provision.schema.json Update link to SSVC_Computed.schema.json Update 055_decision-points_2.md (#250) Two small typo fixes (#253) Replace Utility with Automatable in Deployer tree (#248) Add detail about customization, tree sharing, and decision point scope (#242) add text to point ahead to "Information Changes over Time" bulletize list # Conflicts: # ssvc-calc/SSVC_Computed.schema.json # ssvc-calc/SSVC_Provision.schema.json
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #238
See discussion in #221 for background