Repository navigation
Fix calculator checkbox order dependency in tree pruning - #1160
Merged
Merged
Conversation
check_select() pruned the decision tree incrementally via the rendered DOM nodes at the toggled decision point's depth, so branches hidden by an earlier selection were never updated and reappeared with stale state when re-checked. Checkboxes therefore only behaved when toggled in decision-point order. Rebuild the pruning for the whole tree from the complete checkbox state on every toggle, walking the tree data (saved _schildren) instead of the rendered nodes, so toggle order no longer matters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_select() pruned the decision tree incrementally via the rendered DOM nodes at the toggled decision point's depth, so branches hidden by an earlier selection were never updated and reappeared with stale state when re-checked. Checkboxes therefore only behaved when toggled in decision-point order.
Rebuild the pruning for the whole tree from the complete checkbox state on every toggle, walking the tree data (saved _schildren) instead of the rendered nodes, so toggle order no longer matters.