Complex shading modifiers - #28
Open
Tesshub wants to merge 7 commits into
Open
Conversation
… plot_idf_geometry
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…state Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
WindowShadingControl was missing Zone_Name and Shading_Control_Is_Scheduled (both required by EnergyPlus), and the "with shading" construction only contained the shade/blind/screen material itself instead of that layer plus the window's actual base glazing - an invalid single-layer construction. All three now build a combined construction from the window's current base construction, positioning the shading layer as outermost or innermost depending on Shading_Type. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- document set_screen and both set_complex_fenestration_state input modes (idf_fragment_path from WINDOW, raw description matrices) - fix non-uniform louver demo to use Positions within the actual window height, and drop the building's pre-existing context shading before the first plot_idf_geometry call - add a classic Blind vs BSDF comparison on a dedicated mini building (resources/mini_compare_building.idf), simulating transmitted solar radiation for the same slat geometry represented via WindowMaterial:Blind vs a real WINDOW export (resources/horizontal_venetian_blind_Bsdf.idf), with a caveat on what the observed difference is (and isn't) explained by Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.