Skip to content

Crash when setting shake invocation #16

Description

@schukin

http://crashes.to/s/c4ec0bcd1b7

Reported by @oferRounds. This appears to be caused by React Native calling Buglife setters off the main thread, which Buglife Android isn't currently designed to support. Working on a fix for this currently.

Activity

  1. danhd123 commented on Feb 22, 2019

    @danhd123
    Contributor

    In particular, it's caused by a race condition in setting the invocation method from multiple threads at once or in quick succession (only from different threads; it's fine to call it it repeatedly on the same thread). For now, just don't do that.

  2. oferRounds commented on Mar 4, 2019

    @oferRounds
    Contributor

    @schukin any chance someone from the team could try to fix it? Getting more of this

  3. danhd123 commented on Mar 4, 2019

    @danhd123
    Contributor

    Until there is a fix for this, please refrain from setting the invocation method more than once within any sort of short timespan. React Native Android does not have the same support for choosing a thread/queue to run calls into native packages on, which React Native iOS does. A shim may be required at the Module layer to force calls onto, eg. the main thread (or something serial with a Looper, anyway), but we don't have the engineering resources to put to this right now.

  4. oferRounds commented on Mar 5, 2019

    @oferRounds
    Contributor

    Got you. I understand, no problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions