https://github.com/eventfarm/restforcephp/blob/master/src/Rest/GuzzleRestClient.php#L34
uses the following construct:
public function setBaseUriForRestClient(string $baseUri): void {
$this->client = new \GuzzleHttp\Client($config); // $this->client is private
}This makes impossible to test an app relying upon restforcephp because we can hardly¹ mock the responses.
- You shouldn't use absolute class namespace.
- The GuzzleHttp\Client is a dependency that should be passed as an argument
- With
$this->client being private, we can't overload it.
Could you please improve the situation so that SF depending upon restforce can be tested?
¹ It's actually possible, but using a tons of boilerplate code and workarounds
https://github.com/eventfarm/restforcephp/blob/master/src/Rest/GuzzleRestClient.php#L34
uses the following construct:
This makes impossible to test an app relying upon restforcephp because we can hardly¹ mock the responses.
$this->clientbeing private, we can't overload it.Could you please improve the situation so that SF depending upon restforce can be tested?
¹ It's actually possible, but using a tons of boilerplate code and workarounds