Repository navigation
Conversation
Hrom131
commented
Oct 9, 2026
Hrom131
commented
Collaborator
- This PR suggests a bug fix and I've added the necessary tests.
- This PR introduces a new feature and I've discussed the update in an Issue or with the team.
- This PR is just a minor change like a typo fix.
* added mul_div functions with tests * added zero checks for div_128 and div_256 to be consistent with jet's `divide` * added tests for new helper functions * typo in a test name * utilized convert and split functions * added mul_div docs; moved arithmetic section for u128 and u256 to be consistent with other sections * linting * added docs for new functions * fixed typo * fixed bug in normalize_to_threshold funcs * added more tests to cover new u512 division functionality * bumped simplex version * optimization for calculate_normalizer_base_128 * typo fixes * a couple of new tests for calculate_normalizer_base_128
* fix: pin specific Simplex version for tests.yml * refactor: change simf tests structure * fmt: apply format and add chech into tests.yml file * fmt: apply simfmt to all files * refactor: dedup some of simf/tests functions * refactor: rust part and organize everything by modules * refactor(rename): tests/stdlib functions * refactor: better organization for stdlib tests * refactor: separate lint from tests in workflows * refactor: separate crate::lib from crate::tests
* refactored div functions to panic if the divisor is zero; removed safe_div_128 and safe_div_256 because they duplicate `div` functionality * refactored mul_div functions to panic if the divisor is zero * updated docs * fixed test in common::uint; added -v workaround to ci; fixed typos * fixed comments for checked_div
* added functions for retrieving the AssetId and Amount * renamed asset_id_amount directory to utxo * updated tests to have different amounts for input and output of the same index * optimised getters * restructured doc comment; renamed get_current to get_explicit and get_confidential for consistency * test refactoring: added negative tests; added witness for parity bit; utxo order in a tx is now deterministic; small cleanups * refactoring and typo fixes * test refactoring: added `send_issued` and `create_utxos_with_new_asset` to send some other asset_id; added randomization for amounts; added function to check for pass and failure cases on same utxo. * refactored doc comments * excess doc commets
* added functions for asserting the AssetId and Amount * updated changelog * increased timeout-minutes for github ci
* fix: non-canonical field-element encodings * fix: gej_point_eq aborts instead of returning false for an invalid compressed point * fix: Jacobian point equality accepts off-curve witness points * feat: optimize get_point_eq function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.