Repository navigation
Add the ability to sign statements - #84
Merged
Merged
Conversation
https://github.com/BerryCloud/xapi-java.git into get_attachments
Selindek
marked this pull request as ready for review
March 31, 2023 09:21
thomasturrell
left a comment
thomasturrell
left a comment
Contributor
There was a problem hiding this comment.
I think signing should be done in the client not the model.
thomasturrell
requested changes
Apr 17, 2023
thomasturrell
left a comment
thomasturrell
left a comment
Contributor
There was a problem hiding this comment.
Please add a sample which signs statements.
thomasturrell
requested changes
Apr 17, 2023
thomasturrell
left a comment
thomasturrell
left a comment
Contributor
There was a problem hiding this comment.
Consider adding postSignedStatement (or whatever you think best) to the client.
|
Kudos, SonarCloud Quality Gate passed! |
thomasturrell
self-requested a review
April 17, 2023 15:24
thomasturrell
approved these changes
Apr 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.