Skip to content

add voidStatement and getStatementIterator to xApiEnhancedClient - #144

Merged
thomasturrell merged 11 commits into
mainfrom
Add_enhanced_client
Apr 24, 2023
Merged

thomasturrell merged 11 commits into
mainfrom
Add_enhanced_client

Conversation

@Selindek

Copy link
Copy Markdown
Contributor

No description provided.

@Selindek
Selindek requested a review from thomasturrell April 21, 2023 12:12
@Selindek
Selindek force-pushed the Add_enhanced_client branch from 44a1103 to c1bff81 Compare April 21, 2023 13:03

@thomasturrell thomasturrell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we auto configure the enhanced client?

@thomasturrell thomasturrell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add samples and documentation

Comment thread xapi-client/src/main/java/dev/learning/xapi/client/XapiEnhancedClient.java Outdated
Comment thread xapi-client/src/test/java/dev/learning/xapi/client/XapiEnhancedClientTests.java Outdated
- add sample
- add documentation
- move features to xapiClient
- add toStream() method to StatementIterator
- add test for stream
Comment thread xapi-client/src/test/java/dev/learning/xapi/client/XapiClientTests.java Outdated
Comment thread README.md
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@thomasturrell
thomasturrell merged commit f311bed into main Apr 24, 2023
@thomasturrell
thomasturrell deleted the Add_enhanced_client branch April 24, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants