Skip to content

[WIP] Fix blockconfig limits for donations - #439

Merged
tastybento merged 7 commits into
developfrom
copilot/fix-blockconfig-limits
May 16, 2026
Merged

[WIP] Fix blockconfig limits for donations#439
tastybento merged 7 commits into
developfrom
copilot/fix-blockconfig-limits

Conversation

Copilot AI commented May 15, 2026

Copy link
Copy Markdown
Contributor
  • Fix IslandLevelCalculator.tidyUp() to apply blockconfig limits when computing donated points contribution to island level
  • Fix IslandDonateCommand.performHandDonation() to cap donation at remaining limit capacity
  • Fix IslandDonateCommand.performInvDonation() to cap per-material donation at remaining limit and return excess blocks to inventory
  • Add island.donate.limit-reached locale message to en-US.yml
  • Add tests for limit enforcement in hand and inv donation, and level calculation

Copilot AI linked an issue May 15, 2026 that may be closed by this pull request
Agent-Logs-Url: https://github.com/BentoBoxWorld/Level/sessions/e64dd47d-1dfc-4c51-967f-0646c6d8af1b

Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
@tastybento

Copy link
Copy Markdown
Member

@copilot resolve the merge conflicts in this pull request

…nfig-limits

Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>

Copilot AI commented May 16, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Merged master into the branch (commit 821a79b). No conflicts occurred — the merge resolved cleanly.

@tastybento
tastybento marked this pull request as ready for review May 16, 2026 03:56
@sonarqubecloud

Copy link
Copy Markdown

@tastybento
tastybento merged commit 45f32b7 into develop May 16, 2026
3 checks passed
@tastybento
tastybento deleted the copilot/fix-blockconfig-limits branch May 16, 2026 16:34
tastybento added a commit that referenced this pull request May 16, 2026
…mpts

PR #439 added limits to /is donate hand and inv execution, but the GUI
panel still accepted any amount and both the hand and inv confirm
prompts quoted pre-limit numbers. Apply limits in DonationPanel preview
and confirm (returning excess to the player), and rebuild the hand/inv
prompts to quote the actual amount that will be destroyed. Add a
multi-line limit-notice shown when any material is capped, translated
into all 16 locales.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
tastybento added a commit that referenced this pull request Jul 16, 2026
The lazy-zero / per-chunk handicap / parallel chunk scan work merged via
PRs #435 and #440 (plus follow-up fixes) is not production-ready: admins
running CI snapshot builds saw established island levels reset and
recalculations that only counted newly placed blocks (#448).

That work now continues on the feat/per-chunk-zeroing branch. This
commit restores the stable 2.27.0 calculation engine on develop while
keeping everything safe that landed since 2.27.0:

- Donation fixes: recalc donated points from donatedBlocks (#438),
  enforce blockconfig donation limits in GUI/prompts (#439), cap
  donated counts to current block limits (#443)
- MockBukkit pinned to Maven Central 4.110.0
- Modrinth MC 26.1.2 game version (#444)
- CI publish workflow changes (#445, #446, #447)
- Version stays 2.28.0-SNAPSHOT

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Y6f59pxCkwS8QXtJSe1nq6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

blockconfig limits not working with donation.

2 participants