Preserve authored JavaScript boundaries - #305
Closed
BenCodez wants to merge 9 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[Javascript=...]regions before placeholder replacementCompatibility
Existing authored JavaScript remains unchanged, including normal API calls such as:
Existing PlaceholderAPI/custom placeholders inside JavaScript also remain automatic:
The intentional security change is that a placeholder result can no longer create a new executable
[Javascript=...]marker. Only markers present before placeholder output is applied are executable.Validation
The branch finalization workflow runs
mvn -B -f AdvancedCore/pom.xml packageand removes all temporary implementation files before committing the reviewable tree.Supersedes #302.