You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Minor: typo "Slop" -> "Slot" and missing [[nodiscard]] on Signal::subscribe() #1159
Doc comment typo: "Signal/Slop implementation" should be "Signal/Slot implementation" (line 11).
Signal::subscribe() returns a Subscriber (a shared_ptr that is the only strong
reference keeping the subscription alive; subscribers_ only holds a weak_ptr).
If the caller discards the return value, the shared_ptr refcount drops to zero
immediately, the weak_ptr expires, and the subscription is silently dropped before
it can ever fire. Marking it [[nodiscard]] would catch this footgun at compile time:
Activity
magic-alt commentedon Aug 24, 2026
I'd be happy to pick this up if it is still available. I can keep the change minimal: fix the typo and add [[nodiscard]] to subscribe().
docs: clarify that Precondition is evaluated once per activation, not…
fix: typo Slop->Slot and mark Signal::subscribe() [[nodiscard]] (Beha…