Conversation
- Introduced new image sizes 'landscape' and 'landscape-2x' for use in Gutenberg. - Updated the text domain for translations to 'beapi-frontend-framework'. - Added a filter to display custom image sizes in the Gutenberg editor.
Member
|
Ce sont des choses faites par ARI (la déclaration de tailles). Vaut mieux ne pas grouper tes modifs de textodmain et ça, une PR par sujet normalement |
Contributor
Author
|
Ici c'est plutôt pour gérer les taille dans gutenberg pour les patterns etc... ARI n'est pas utilisé pour les images dans gutenberg. Elles utilisent bien ces tailles là. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Theme bootstrap changes only—new thumbnails and a text-domain fix—with no auth, data, or security impact.
Overview
Registers landscape (600×400) and landscape-2x (1200×800) hard-cropped image sizes during theme setup, and wires them into the block editor by filtering
image_size_names_chooseso editors can pick Landscape - 600 x 400 in Gutenberg.Also switches
load_theme_textdomainfromframework-textdomaintobeapi-frontend-frameworkso the new size label uses the correct theme text domain.Reviewed by Cursor Bugbot for commit 43535fd. Bugbot is set up for automated code reviews on this repo. Configure here.