Repository navigation
Make http_client's max_retries configurable #432
Description
Symptom
The one-time retry introduced by #326 seems to be insufficient:
microsoft-authentication-library-for-python/msal/application.py
Lines 423 to 425 in 62752ad
Transient ConnectionError can still makes MSAL fail: #431
Alternatives
Of course I can provide my HTTP client, but this seems too heavy for such as small parameter tweak.
Activity
rayluo commentedon Nov 3, 2021
This issue was created when #431 was observed. Now we have addressed #431 in its corresponding PR, by providing clearer error message. End user will then make educated decision on manual retry when needed. So, there is less need for an app to automatically choose a max retries value.
Besides,
max_retriesis an http layer behavior. It does not really belong to the MSAL or OAuth2 layer. We choose to not make this change.jiasli commentedon Jul 30, 2024
I want to reopen this issue as Azure/azure-cli#29452 is requesting managed identity authentication's retry to be configurable.
doubleyewdee commentedon Jul 30, 2024
Jiashuo Li (@jiasli) yes, we'd appreciate being able to tune retries here (it looks like there's at least one retry which is better than what we have today already so that's excellent)
rayluo commentedon Aug 1, 2024
Instead, please consider use a customized
http_clientwith your own retry logic instead.Note that the default retry-once behavior is only available in MSAL Python's non-Managed Identity code path. For managed identity, the current API requires the caller to provide an
http_clientanyway.