Repository navigation
{Core} Fix #33996: Intermittent _DeadlockError in AAZ long-running operation - #34201
Open
Ethan Yang (necusjz) wants to merge 1 commit into
Open
Ethan Yang (necusjz) wants to merge 1 commit into
Ethan Yang (necusjz) wants to merge 1 commit into
Conversation
microsoft-github-policy-service
Bot
requested a review
from Yong Zhang (yonzhan)
October 9, 2026 05:09
microsoft-github-policy-service
Bot
added
Auto-Assign
Collaborator
|
Core |
Yeming Liu (isra-fel)
approved these changes
Oct 9, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The regression test does not currently verify that the import occurs before the polling thread starts.
1 open finding
What changed in this PR
Fixes intermittent AAZ polling deadlocks by eagerly importing requests before starting the polling thread.
Changes:
- Preloads
requestsbefore worker-thread creation. - Adds regression coverage for import timing.
| File | Description |
|---|---|
aaz/_poller.py |
Moves lazy dependency loading onto the main thread. |
tests/test_aaz_poller.py |
Adds polling-thread import regression coverage. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+14
to
+26
| def test_requests_imported_before_polling_thread(self): | ||
| loaded = [] | ||
|
|
||
| def polling_generator(): | ||
| loaded.append("requests" in sys.modules) | ||
| yield from () | ||
|
|
||
| with mock.patch.dict(sys.modules): | ||
| for name in [n for n in sys.modules if n == "requests" or n.startswith("requests.")]: | ||
| del sys.modules[name] | ||
| AAZLROPoller(polling_generator=polling_generator(), result_callback=None).wait() | ||
|
|
||
| self.assertEqual(loaded, [True]) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Fix: #33996
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.