Repository navigation
{aks-preview} Add --node-public-ip-prefix-ids to az aks nodepool update - #10420
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Legacy singular prefix state must be cleared, and the new update behavior needs dedicated tests.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds in-place node public IP prefix updates for AKS node pools.
Changes:
- Registers and applies
--node-public-ip-prefix-ids. - Adds command help and an update example.
- Bumps the extension version and history.
| File | Description |
|---|---|
setup.py |
Bumps version to 22.0.0b10. |
HISTORY.rst |
Documents the feature. |
custom.py |
Threads the new parameter into updates. |
agentpool_decorator.py |
Applies prefix IDs to the network profile. |
_params.py |
Registers the update argument and validator. |
_help.py |
Adds help and an example. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Pushed
|
|
Pushed Root cause: the prior commit added a second Fix: merged |
|
aks-preview |
FumingZhang
left a comment
There was a problem hiding this comment.
lgtm
Please rebase your branch onto main to pick up the latest commits and work around the current CI check issue. Christine DOSSA (@christine33-creator)
317a49a to
5306ca3
Compare
|
Thanks FumingZhang! Rebased onto the latest |
|
Copilot resolve the merge conflicts in this pull request |
Adds the in-place add/replace path for dual-stack node public IP prefixes on an existing node pool. An accepted change rolls the pool so existing nodes are recreated with the new public IPs. Bumps aks-preview to 22.0.0b10.
…add update-path unit tests; linter exclusions for aks nodepool update
…aks nodepool update' key The previous commit added a second 'aks nodepool update:' top-level key to linter_exclusions.yml. YAML duplicate keys resolve last-wins, so the existing block (further down the file) silently overrode the new one and dropped the node_public_ip_prefix_ids option_length_too_long exclusion, leaving the HIGH severity linter failure. Merge the parameter exclusion into the existing key and drop the redundant require_wait entry (already covered by the 'aks nodepool' group exclusion).
5306ca3 to
403c5fe
Compare


Related command
az aks nodepool update --node-public-ip-prefix-idsDescription
Extends the dual-stack node public IP prefix flag (
--node-public-ip-prefix-ids/nodePublicIPPrefixIDs) toaz aks nodepool update. The flag already ships onaz aks createandaz aks nodepool add; this adds the in-place add/replace path so an existing node pool's assigned IPv4/IPv6 public IP prefixes can be grown (e.g. add an IPv6 prefix to an IPv4-only pool) or replaced. An accepted change rolls the pool so existing nodes are recreated with the new public IPs.Preview-gated behind the
NodePublicIPv6PrefixPreviewfeature flag, consistent with create / nodepool add.Changes
_params.py— register--node-public-ip-prefix-idsonaks nodepool update(reusesvalidate_node_public_ip_prefix_ids).agentpool_decorator.py—AKSPreviewAgentPoolUpdateDecorator.update_network_profileappliesnode_public_ip_prefix_i_ds(the existing context getter already works in UPDATE mode).custom.py— thread the parameter throughaks_agentpool_update._help.py— parameter help + example.HISTORY.rst/setup.py— bumpaks-previewto22.0.0b10.This checklist is used to make sure that common guidelines for a pull request are followed.
HISTORY.rstupdated and the extension version bumped.azdev test aks-preview) run locally.