Repository navigation
{ARO} Migrate validator to aaz-based implementation - #10405
Merged
Merged
Conversation
Copilot started reviewing on behalf of
William (william051200)
September 29, 2026 01:14
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The migration preserves validation behavior, uses the correct AAZ arguments, and includes aligned tests and release metadata.
Review effort: Balanced
Findings: None
What changed in this PR
Migrates ARO Disk Encryption Set validation from the Compute SDK to the Azure CLI AAZ command.
Changes:
- Replaces SDK validation with AAZ
Show. - Updates validator unit tests.
- Bumps the extension version and release history.
| File | Description |
|---|---|
src/aro/setup.py |
Bumps version to 1.0.14. |
src/aro/HISTORY.rst |
Documents the validator migration. |
src/aro/azext_aro/_validators.py |
Uses AAZ for Disk Encryption Set lookup. |
src/aro/azext_aro/tests/latest/standard/unit/test_validators.py |
Tests the new AAZ invocation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
ARO |
Teresa Ritorto (teresaritorto)
approved these changes
Oct 6, 2026
Ethan Yang (necusjz)
approved these changes
Oct 6, 2026
Collaborator
|
[Release] Update index.json for extension [ aro-1.0.14 ] : https://dev.azure.com/msazure/One/_build/results?buildId=184310285&view=results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration from mgmt.compute to aaz-based
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.