consider Http Status codes OK and Created when waiting for long running operations due to a change in the Api Management Rest API

[David Schneiderbauer (daviian)]

resolves #513

A change in the recent preview version 2023-09-01-preview removed the http Status Code 'Accepted' and now uses 'OK' or 'Created' in a similar fashion as 'Accepted' before.

[guythetechie]

David Schneiderbauer (@daviian) - I'm concerned about infinite loops with this code. OK and Created don't necessarily mean long-running operations. How do you differentiate between an OK that's long-running and one that's not?

[guythetechie]

For OK and Created, maybe check for a provisioningState property that's in progress?

[David Schneiderbauer (daviian)]

I've added the check as requested.

There is a similar check in common/Api.cs:626 that checks if the creation is still in progress.
Here the status code however is required to be Created which, according to the API spec, is never responded with.
So this code should always return false no matter what in the first if block. Not sure what the intention was back when it was added

[guythetechie]

Looks good, thanks!

[Wael Kdouh (waelkdouh)]

Thanks David Schneiderbauer (@daviian) for your contributions and making apiops better for the community!

[Emil Karlsson (e-karlsson)]

Unfortunately we still see this issue in version v6.0.2-alpha.1.0.3. After retrigger publish it worked fine.

info: publisher[0]
      Putting policy policy for operation get-post in API posts...
crit: publisher[0]
      Application failed.
      System.Net.Http.HttpRequestException: HTTP request to URI https://management.azure.com/subscriptions/***/resourceGroups/rg-apim/providers/Microsoft.ApiManagement/service/apim-cicd-test/apis/posts/operations/get-post/policies/policy?api-version=2023-09-01-preview failed with status code 400. Content is '{"error":{"code":"ValidationError","message":"Entity with specified identifier not found","details":null}}'.

Anyone else?

[David Schneiderbauer (daviian)]

Emil Karlsson (@e-karlsson) Sorry can't help out, for me everything works now as expected.