Better to add timeout/interval to the Instruction class instead of ConditionWatcher? #4

Activity

1. polok commented on Jul 26, 2017

   

   polok

   on Jul 26, 2017

   More actions

   You have 👍 from me :)
2. FisherKK commented on Jul 26, 2017

   

   FisherKK

   on Jul 26, 2017

   Last edited by FisherKK

   Collaborator

   More actions

   Hey @hkmushtaq

   Sounds not bad I think.
   Usually I created wrapping code around my ConditionWatcher's waitForCondition method. It resulted in even 15+ variations of something like this:

       public void waitForCondition(String key, int waitTimeInMs, int interval, Bundle data) throws Exception {
           Instruction instruction = InstructionStore.getInstructionForKey(key);
           instruction.setData(data);
           ConditionWatcher.setTimeoutLimit(waitTimeInMs);
           ConditionWatcher.setWatchInterval(interval);
           ConditionWatcher.waitForCondition(instruction);
           ConditionWatcher.setWatchInterval(ConditionWatcher.DEFAULT_INTERVAL);
       }
   

   Your idea could reduce it so I think it's a good direction. Go ahead with PR, I will be happy to check and merge it :)
3. hkmushtaq commented on Jul 26, 2017

   

   hkmushtaq

   on Jul 26, 2017

   Author

   More actions

   Awesome, I'll get to work on refactoring it!