Repository navigation
#28 Final Launcher Functions - #39
Merged
Merged
Conversation
Launcher notifications no longer stack on top of each other, "open in editor" now works, and more
Av3boy
added
bug
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contents
Finished the launcher functions, i.e. the projects can now be launched from the launcher that the editor then opens. Editor is now also able to launch the projects.
We resolve it by:
Fixing the System.Diasnostics.Process startup logic.
Additionally:
Fixed the notification system so that any issues that occur within the process starting call are bubbled up to the NotificationService which shows those errors within the launcher.
Checklist
mainto my branch.