Added support for dark and light theme logo - #143
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The README currently references the same SVG for both dark and light sources, so it does not implement the stated dark/light logo behavior.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the repository README header logo markup to support theme-aware rendering (different logo variants for dark vs light mode), improving visibility across GitHub UI themes.
Changes:
- Replaced the single
<img>logo with a<picture>element and theme-targeted<source>entries. - Added an
altattribute to the logo image for better accessibility.
File summaries
| File | Description |
|---|---|
| README.md | Switches README logo markup to <picture> with dark/light <source> entries to enable theme-aware logo rendering. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+3
to
+5
| <source media="(prefers-color-scheme: dark)" srcset="Resources/icon.svg"/> | ||
| <source media="(prefers-color-scheme: light)" srcset="Resources/icon.svg"/> | ||
| <img alt="The SharpEngine logo." align="center" width="100" src="Resources/icon.svg"/> |
Av3boy
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying out rendering a white logo in dark theme and black logo in light mode so that it is more clearly visible.