#21 Structural changes by Av3boy · Pull Request #142 · Av3boy/SharpEngine

Av3boy · 2026-08-26T20:43:01Z

#21 Structural changes

Checklist

I have merged the latest changes from main to my branch.
I have tested my changes and any affected components.
I have added the proper documentation about my changes
I have made sure there is no overlapping work.
I have discussed any / all issues brought up from code review.

Doesn't work quite yet

Everything after this point needs to have a structure and proper planning. It's been a wild west until now

We need to start figuring out the shared repo and how the "main" repo will build as open source

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

🟡 Changes recommended

There are multiple build- and runtime-blocking issues (logger type mismatch in EngineHandler inheritance, busy-spin in Engine.Initialize, WindowHandler self-deadlock/blocking Run call, and broken project/solution references) that must be resolved before merge.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR performs broad structural refactoring across the engine, introducing new managers (input/shader/renderer), a DI-based app/engine bootstrap, and a new in-repo OBJ loader project while updating examples and tests to match.

Changes:

Refactors window lifecycle and per-frame input/render orchestration (Window/SilkWindow + new managers).
Introduces a DI-driven engine/app registration model (SharpEngine.Core.DependencyInjection) and updates examples accordingly.
Adds a new SharpEngine.Core.ObjLoader project (parsers/loaders/datastore) and updates solution/test wiring.

File summaries

File	Description
Tests/SharpEngine.Core.ArchitectureTests/SharpEngine.Core.ArchitectureTests.csproj	Adds test SDK + xUnit v3 and references Core project.
Tests/SharpEngine.Core.ArchitectureTests/GameObjectTests.cs	Adds architecture test for GameObject constructors.
Tests/SharpEngine.Core.ArchitectureTests/Class1.cs	Removes placeholder class.
Tests/ObjLoader.Test/SharpEngine.Core.ObjLoader.Tests.csproj	Updates ObjLoader test project references.
SharpEngine.slnx	Updates solution project paths (tests + ObjLoader project).
SharpEngine.Dto/SharpEngine.Core.Dto.csproj	Adds new DTO project scaffold.
SharpEngine.Dto/Class1.cs	Adds placeholder class for DTO project.
SharpEngine.Core/Windowing/Window.cs	Refactors window initialization, input, shader usage, and renderer execution.
SharpEngine.Core/Windowing/SilkWindow.cs	Adjusts window abstraction: title handling, background color, events, and CurrentWindow nullability.
SharpEngine.Core/SharpEngine.Core.csproj	Adjusts compile includes and adds IO project reference; removes some packages.
SharpEngine.Core/ShaderManager.cs	Introduces ShaderManager wrapper around shader loading/usage.
SharpEngine.Core/Scenes/SceneNode.cs	Moves EmptyNode out; adds initialization hooks and lifecycle methods.
SharpEngine.Core/Scenes/Scene.cs	Converts Scene into SaveableFile-based type and removes inline JSON persistence code.
SharpEngine.Core/Scenes/EmptyNode.cs	Adds EmptyNode as separate file.
SharpEngine.Core/Rendering/ShaderParameterBinder.cs	Makes logger optional and uses telemetry logger factory helper.
SharpEngine.Core/Renderers/UIRenderer.cs	Updates logging creation and adds UIElement query on attach.
SharpEngine.Core/RendererManager.cs	Introduces renderer discovery/selection/execution manager.
SharpEngine.Core/InputManager.cs	Introduces centralized input context + event dispatch.
SharpEngine.Core/Handlers/WindowHandler.cs	Reworks window handler lifecycle and queueing model.
SharpEngine.Core/Handlers/EngineHandler.cs	Changes handler start/stop model and cancellation handling.
SharpEngine.Core/Entities/UI/UIElement.cs	Moves UIElement toward component-based model and GL init via OnInitialized.
SharpEngine.Core/Entities/UI/MeshRenderer.cs	Makes MeshRenderer a component.
SharpEngine.Core/Entities/UI/Layouts/LayoutBase.cs	Makes layouts transformable UI nodes with spacing.
SharpEngine.Core/Entities/UI/Layouts/GridLayout.cs	Expands grid layout to auto-position UIElements with optional bounds.
SharpEngine.Core/Entities/UI/DraggableUIElement.cs	Adds new draggable UI element type.
SharpEngine.Core/Entities/Interfaces/IComponent.cs	Adds component interface + GameObject-related extension helpers.
SharpEngine.Core/Entities/Interfaces/IClickable.cs	Adds click interface + component/event payload types.
SharpEngine.Core/Entities/GameObject.cs	Shifts GameObject toward components/material default helper.
SharpEngine.Core/EngineServiceManager.cs	Changes handler registration/startup pattern.
SharpEngine.Core/Engine.cs	Converts Engine from static to instance, adds handler startup loop and version check.
SharpEngine.Core/DependencyInjection/ServiceCollectionExtensions.cs	Removes old window DI registration approach.
SharpEngine.Core/Abstractions/IGame.cs	Adds Window property and OnAfterRender hook to Game abstraction.
SharpEngine.Core/_Resources/Shaders/uiShader.vert	Switches UI vertex transform to pixel-space ortho projection approach.
SharpEngine.Core.Shared/Debug.cs	Adds Serilog-based debug helper scaffold.
SharpEngine.Core.ObjLoader/TypeParsers/VertexParser.cs	Adds OBJ vertex parser.
SharpEngine.Core.ObjLoader/TypeParsers/UseMaterialParser.cs	Adds OBJ usemtl parser.
SharpEngine.Core.ObjLoader/TypeParsers/TypeParserBase.cs	Adds base parser keyword matching helper.
SharpEngine.Core.ObjLoader/TypeParsers/TextureParser.cs	Adds OBJ texture coordinate parser.
SharpEngine.Core.ObjLoader/TypeParsers/SmoothingGroupParser.cs	Adds OBJ smoothing group parser.
SharpEngine.Core.ObjLoader/TypeParsers/ObjectNameParser.cs	Adds OBJ object-name parser.
SharpEngine.Core.ObjLoader/TypeParsers/NormalParser.cs	Adds OBJ normal parser.
SharpEngine.Core.ObjLoader/TypeParsers/MaterialLibraryParser.cs	Adds OBJ material-library parser integration.
SharpEngine.Core.ObjLoader/TypeParsers/ITypeParser.cs	Adds type parser interface.
SharpEngine.Core.ObjLoader/TypeParsers/GroupParser.cs	Adds OBJ group parser.
SharpEngine.Core.ObjLoader/TypeParsers/FaceParser.cs	Adds OBJ face parser.
SharpEngine.Core.ObjLoader/SharpEngine.Core.ObjLoader.csproj	Adds new in-repo ObjLoader project.
SharpEngine.Core.ObjLoader/Loaders/ObjLoader/ObjLoaderFactory.cs	Adds loader factory with extension-based dispatch.
SharpEngine.Core.ObjLoader/Loaders/ObjLoader/ObjLoader.cs	Adds OBJ file loader core.
SharpEngine.Core.ObjLoader/Loaders/ObjLoader/FileManager.cs	Adds file wrapper for testability.
SharpEngine.Core.ObjLoader/Loaders/MaterialLoader/MaterialLibraryLoaderFacade.cs	Adds facade for MTL loading relative to OBJ path.
SharpEngine.Core.ObjLoader/Loaders/MaterialLoader/MaterialLibraryLoader.cs	Adds MTL parser/loader implementation.
SharpEngine.Core.ObjLoader/Loaders/MaterialLoader/IMaterialLibraryLoaderFacade.cs	Adds facade interface.
SharpEngine.Core.ObjLoader/Loaders/LoaderBase.cs	Adds shared file parsing base.
SharpEngine.Core.ObjLoader/Loaders/IFileManager.cs	Adds file manager abstraction.
SharpEngine.Core.ObjLoader/ISmoothingGroupDataStore.cs	Adds smoothing-group datastore interface.
SharpEngine.Core.ObjLoader/IObjectNameDataStore.cs	Adds object-name datastore interface.
SharpEngine.Core.ObjLoader/IMaterialDataStore.cs	Adds material datastore interface.
SharpEngine.Core.ObjLoader/DataStore.cs	Adds OBJ parsing datastore implementation.
SharpEngine.Core.DependencyInjection/WindowServiceCollectionExtensions.cs	Adds new DI registration for WindowHandler + Window creation/configure hooks.
SharpEngine.Core.DependencyInjection/SharpEngine.Core.DependencyInjection.csproj	Adds new DI project with MS.Extensions deps.
SharpEngine.Core.DependencyInjection/HandlerRegistrationBuilder.cs	Adds handler registration builder pattern.
SharpEngine.Core.DependencyInjection/EngineServiceCollectionExtensions.cs	Adds AddEngine() service registration.
SharpEngine.Core.DependencyInjection/EngineRegistrationBuilder.cs	Adds engine registration builder.
SharpEngine.Core.DependencyInjection/AppBuilder.cs	Adds DI app builder for configuration/services.
SharpEngine.Core.DependencyInjection/App.cs	Refactors app run to resolve engine/game and start engine.
SharpEngine.Core.Components/Properties/Material.cs	Minor import adjustment for shaders.
Examples/Tutorial 4.1 - Model Loading/Tutorial 4.1 - Model Loading.csproj	Adds reference to new ObjLoader project.
Examples/MultipleWindows/Program.cs	Updates handler start and input wiring for new InputManager location.
Examples/MinecraftClone/Program.cs	Migrates to AddEngine()/WindowHandler registration and DI changes.
Examples/MinecraftClone/Minecraft.csproj	Adds dependency injection project reference.
Examples/MinecraftClone/Minecraft.cs	Updates UI initialization to use new window bounds + grid layout; updates OnAfterRender override.

Review details

Suppressed comments (1)

SharpEngine.Core/Handlers/WindowHandler.cs:121

WindowHandler.DequeueWindows calls window.Run() inside the handler loop. Run() is typically a blocking native-window loop, so this will prevent managing additional windows and prevent the outer ExecuteAsync loop from progressing.

Files reviewed: 45/72 changed files
Comments generated: 7
Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

        protected readonly ILogger<EngineHandler> Logger;

        /// <summary>
        ///     Initializes a new instance of <see cref="EngineHandler"/>.
        /// </summary>


+        ServicesManager.StartHandlers(_cancellationTokenSource);

-        Initialize();
-        Services.RegisterHandler(new WindowHandler(window));
+        while (!_cancellationTokenSource.Token.IsCancellationRequested)
+        {



+        foreach (var window in _windows)
+            window.Close();
+
+        await StopAsync();
    }


+using System.Reflection;
+using SharpEngine.Core.Entities;
+using Xunit;
+
+namespace SharpEngine.Core.ArchitectureTests;
+
+public class GameObjectTests
+{
+
+    [Fact]
+    public void GameObjects_Should_Not_Have_Public_Constructors()
+    {
+        var gameObjectTypes = typeof(GameObject).Assembly
+            .GetTypes()
+            .Where(t =>
+                !t.IsAbstract &&
+                typeof(GameObject).IsAssignableFrom(t));


  <Folder Name="/Tests/IntegrationTests/" />
  <Folder Name="/Tests/UnitTests/">
-    <Project Path="Tests/ObjLoader.Test/SharpEngine.Core.ObjLoader.Tests.csproj">
+    <Project Path="Tests/SharpEngine.Core.ObjLoader.Test/SharpEngine.Core.ObjLoader.Tests.csproj">


  <ItemGroup>
    <ProjectReference Include="..\..\ObjLoader\SharpEngine.Core.ObjLoader.csproj" />
+    <ProjectReference Include="..\..\SharpEngine.Core.ObjLoader\SharpEngine.Core.ObjLoader.csproj" />
  </ItemGroup>


    <ItemGroup>
      <ProjectReference Include="..\..\ObjLoader\SharpEngine.Core.ObjLoader.csproj" />
      <ProjectReference Include="..\..\SharpEngine.Core.Components\SharpEngine.Core.Components.csproj" />
+      <ProjectReference Include="..\..\SharpEngine.Core.ObjLoader\SharpEngine.Core.ObjLoader.csproj" />
      <ProjectReference Include="..\..\SharpEngine.Core\SharpEngine.Core.csproj" />
    </ItemGroup>


sonarqubecloud · 2026-09-20T12:03:34Z

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Av3boy · 2026-09-20T12:19:14Z

For the time being, I want to get this and the other PRs in that waiting so that there is as little blockers for the first release as possible. I'll address any/all SonarCloud findings in a separate PR later

Av3boy and others added 15 commits July 18, 2026 01:49

#21 Input and windowing improvements

196faa7

#21 Fix window load and input (wip)

f2a4cf6

#21 Fix UI rendering to use pixel

0715fa2

#21 UI alignment works (WIP)

93673c3

#21 Rearrange logic into the grid container (WIP)

ad9d208

Doesn't work quite yet

#21 Temp

117aefb

Temp

29fff27

Placeholder commit

958a83b

Everything after this point needs to have a structure and proper planning. It's been a wild west until now

Temp

968d582

We need to start figuring out the shared repo and how the "main" repo will build as open source

Structural consistency cleanup

ee1e2f1

Add Copilot MCP config

8660a46

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Add copilot instruction file

601ae10

Update docs

08cfbfd

Structural updates

db71057

Fix renderers

e2fe85b

Av3boy added this to the SharpEngine 1.0 MVP milestone Aug 26, 2026

Av3boy requested a lite review from Copilot August 26, 2026 20:43

Av3boy self-assigned this Aug 26, 2026

Av3boy added this to A sharp plan Aug 26, 2026

Av3boy added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request rendering Rendering related issues / questions core The issue is related to the Core library. labels Aug 26, 2026

Copilot started reviewing on behalf of Av3boy August 26, 2026 20:43 View session

Copilot AI reviewed Aug 26, 2026

View reviewed changes

Av3boy added 4 commits August 27, 2026 00:23

Add mcp for sonarcloud

e63ab43

Project improvements

e3f83ce

Fixes & Cleanup

b3d3113

Merge remote-tracking branch 'origin/21-av-temp' into 21-av-temp

28f8afb

Av3boy added 2 commits September 20, 2026 14:57

Merge remote-tracking branch 'origin/dev' into 21-av-temp

2bdc1ff

#21 Fix project reference paths

6b90697

Av3boy merged commit 00c1182 into dev Sep 20, 2026
3 of 4 checks passed

github-project-automation Bot moved this to Done in A sharp plan Sep 20, 2026

Navigation Menu

#21 Structural changes - #142

#21 Structural changes#142
Av3boy merged 21 commits into
devfrom
21-av-temp

Av3boy commented Aug 26, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

sonarqubecloud Bot commented Sep 20, 2026

Uh oh!

Av3boy commented Sep 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Av3boy commented Aug 26, 2026

Contents

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Suppressed comments (1)

Uh oh!

sonarqubecloud Bot commented Sep 20, 2026

Quality Gate failed

Uh oh!

Av3boy commented Sep 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants