Skip to content

#67 Shader Improvements - #136

Merged
Av3boy merged 11 commits into
devfrom
67-av-shader-improvements
Jun 28, 2026
Merged

Av3boy merged 11 commits into
devfrom
67-av-shader-improvements

Merge remote-tracking branch 'origin/dev' into 67-av-shader-improvements

6e42a37
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jun 28, 2026 in 9s

Annotations

Check warning on line 59 in SharpEngine.Core/Entities/Lights/PointLight.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'System.NullReferenceException' should not be thrown by user code.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF57b5VpPISvuiaN&open=AZ8PHF57b5VpPISvuiaN&pullRequest=136

Check warning on line 140 in SharpEngine.Core/Rendering/ShaderParameterBinder.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make sure that this accessibility bypass is safe here.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF6Yb5VpPISvuiaP&open=AZ8PHF6Yb5VpPISvuiaP&pullRequest=136

Check warning on line 15 in SharpEngine.Core/Entities/UI/MeshRenderer.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this 'TODO' comment.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF25b5VpPISvuiaH&open=AZ8PHF25b5VpPISvuiaH&pullRequest=136

Check warning on line 24 in SharpEngine.Core/Entities/Lights/PointLight.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unnecessary cast to 'Vector3'.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF57b5VpPISvuiaM&open=AZ8PHF57b5VpPISvuiaM&pullRequest=136

Check warning on line 78 in Examples/MinecraftClone/Minecraft.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF74b5VpPISvuiaW&open=AZ8PHF74b5VpPISvuiaW&pullRequest=136

Check warning on line 156 in Examples/Tutorial 4.1 - Model Loading/Program.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'System.NullReferenceException' should not be thrown by user code.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF8Fb5VpPISvuiac&open=AZ8PHF8Fb5VpPISvuiac&pullRequest=136

Check warning on line 20 in SharpEngine.Core.Components/Properties/Material.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'int' should not be explicitly used as the underlying type.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF80b5VpPISvuiag&open=AZ8PHF80b5VpPISvuiag&pullRequest=136

Check warning on line 222 in SharpEngine.Core.Components/Properties/Shaders/ShaderProgram.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this 'TODO' comment.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF8-b5VpPISvuiak&open=AZ8PHF8-b5VpPISvuiak&pullRequest=136

Check warning on line 10 in SharpEngine.Core.Components/Properties/Shaders/Shader.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'ShaderProgram' implements 'IDisposable' so 'IDisposable' can be removed from the inheritance list.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF9Kb5VpPISvuian&open=AZ8PHF9Kb5VpPISvuian&pullRequest=136

Check warning on line 46 in SharpEngine.Core/Entities/GameObject.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF5vb5VpPISvuiaJ&open=AZ8PHF5vb5VpPISvuiaJ&pullRequest=136

Check warning on line 88 in Examples/MinecraftClone/Minecraft.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF74b5VpPISvuiaX&open=AZ8PHF74b5VpPISvuiaX&pullRequest=136

Check warning on line 71 in SharpEngine.Core/Entities/GameObject.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this 'TODO' comment.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF5vb5VpPISvuiaL&open=AZ8PHF5vb5VpPISvuiaL&pullRequest=136

Check warning on line 31 in SharpEngine.Core.Components/Properties/Shaders/ShaderExtensions.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this 'TODO' comment.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF9Wb5VpPISvuiao&open=AZ8PHF9Wb5VpPISvuiao&pullRequest=136

Check failure on line 155 in SharpEngine.Core/Windowing/Window.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This method signature overlaps the one defined on line 107, the default parameter value can only be used with named arguments.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF64b5VpPISvuiaT&open=AZ8PHF64b5VpPISvuiaT&pullRequest=136

Check warning on line 124 in Examples/Tutorial 4.1 - Model Loading/Program.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'System.NullReferenceException' should not be thrown by user code.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF8Fb5VpPISvuiaf&open=AZ8PHF8Fb5VpPISvuiaf&pullRequest=136

Check warning on line 28 in SharpEngine.Core/Entities/GameObject.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this 'TODO' comment.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF5vb5VpPISvuiaK&open=AZ8PHF5vb5VpPISvuiaK&pullRequest=136

Check warning on line 65 in SharpEngine.Core/Entities/Lights/SpotLight.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'System.NullReferenceException' should not be thrown by user code.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF6Nb5VpPISvuiaO&open=AZ8PHF6Nb5VpPISvuiaO&pullRequest=136

Check warning on line 159 in Examples/Tutorial 4.1 - Model Loading/Program.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'System.NullReferenceException' should not be thrown by user code.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF8Fb5VpPISvuiad&open=AZ8PHF8Fb5VpPISvuiad&pullRequest=136

Check warning on line 97 in Examples/Tutorial 4.1 - Model Loading/Program.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'System.NullReferenceException' should not be thrown by user code.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF8Fb5VpPISvuiaZ&open=AZ8PHF8Fb5VpPISvuiaZ&pullRequest=136

Check warning on line 18 in SharpEngine.Core/Windowing/SilkWindow.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this 'TODO' comment.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF7Mb5VpPISvuiaU&open=AZ8PHF7Mb5VpPISvuiaU&pullRequest=136

Check warning on line 27 in SharpEngine.Core/Entities/UI/UIElement.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this 'TODO' comment.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF5hb5VpPISvuiaI&open=AZ8PHF5hb5VpPISvuiaI&pullRequest=136

Check failure on line 47 in SharpEngine.Core.Components/Properties/Material.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This method signature overlaps the one defined on line 38, the default parameter value can only be used with named arguments.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF80b5VpPISvuiai&open=AZ8PHF80b5VpPISvuiai&pullRequest=136

Check warning on line 153 in Examples/Tutorial 4.1 - Model Loading/Program.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'System.NullReferenceException' should not be thrown by user code.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF8Fb5VpPISvuiab&open=AZ8PHF8Fb5VpPISvuiab&pullRequest=136

Check warning on line 93 in SharpEngine.Core/Renderers/Renderer.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this 'TODO' comment.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF7db5VpPISvuiaV&open=AZ8PHF7db5VpPISvuiaV&pullRequest=136

Check warning on line 92 in SharpEngine.Core.Components/Properties/Shaders/ShaderProgram.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant jump.

See more on https://sonarcloud.io/project/issues?id=Av3boy_SharpEngine&issues=AZ8PHF8-b5VpPISvuial&open=AZ8PHF8-b5VpPISvuial&pullRequest=136