Repository navigation
Conversation
Introduced obj loader, abstracted some functionality into separate projects, added placeholders for test projects
Textures still missing and the framerate is very bad
There was a problem hiding this comment.
Pull Request Overview
This PR revisits the model loading approach to support custom .obj mesh files by switching from using the Material‐ and Mesh‑based assignment to a Model property, and it updates logging calls to use Debug.Log instead of Console.WriteLine.
- Changed property assignment in BlockBase to use Model instead of separately assigning Material and Meshes.
- Updated logging calls across Editor files with Debug.Log methods and added structured logging parameters.
- Removed several core files (e.g. Texture, Shader, MeshService, etc.) as part of refactoring to transition to a new model loading approach.
Reviewed Changes
Copilot reviewed 180 out of 184 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Examples/MinecraftClone/Block/BlockBase.cs | Updated assignment to use Model instead of Material/Meshes. |
| Editor/Windows/PropertiesWindow.cs | Replaced Console.WriteLine with Debug.Log.Error and updated exception variable. |
| Editor/Windows/ImGuiWindowBase.cs | Updated logging calls and TODO comment with new reference. |
| Editor/Windows/AssetsWindow.cs | Adjusted TODO comment numbering. |
| Editor/Windows/ActionsMenuWindow.cs | Replaced log methods with structured logging and updated TODOs. |
| Editor/Program.cs | Revised logging calls and exception handling naming consistency. |
| Editor/EditorWindow.cs | Numerous logging updates and TODO renumbering for clarity. |
| (Multiple Core files: TextureService.cs, Texture.cs, Shader.cs, MeshService.cs, Mesh.cs, Material.cs, GameObject.cs, Debug.cs, IRenderable.cs) | Removed outdated or obsolete core files as part of the refactoring. |
Files not reviewed (4)
- Core/Shaders/shader.frag: Language not supported
- Core/SharpEngine.Core.csproj: Language not supported
- Directory.Build.props: Language not supported
- Editor/SharpEngine.Editor.csproj: Language not supported
|
Owner
Author
|
The issues reported by sonar cloud are mostly related to the known issues and the unsafe code blocks are marked as obsolete so they are find to push to dev. They will be addressed before release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


#2 Load .obj mesh
Contents
This PR is trying to resolve:
The engine needs the ability to load both primitive types and custom models. Custom models are a key factor in any rendering engine.
We resolve it by:
Tried to use a custom implementation which for a reason or another does not work. To use an intermediate solution that works, marked a Model_Old class as obsolete and used it to load models.
The approach in this PR has an issue where the textures are not being loaded correctly. This will be fixed in an upcoming PR to keep the changes small enough.
Checklist
mainto my branch.