Skip to content

Add Forked repos stream - #10

Merged
joaopamaral merged 8 commits into
masterfrom
repos-forked-streams
Jan 17, 2025
Merged

Add Forked repos stream#10
joaopamaral merged 8 commits into
masterfrom
repos-forked-streams

Conversation

@joaopamaral

@joaopamaral joaopamaral commented Jan 13, 2025

Copy link
Copy Markdown

Description of change

Adds the repos, repo_forked_parents, and repo_forked_compares streams at the Organization level.

Rollback steps

  • revert this branch

@joaopamaral
joaopamaral marked this pull request as ready for review January 14, 2025 21:19
@joaopamaral
joaopamaral requested a review from a team January 14, 2025 21:19

@Khrol Khrol left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

Comment thread tap_github/streams.py Outdated
Comment thread tap_github/streams.py
Comment thread tap_github/client.py Outdated
@joaopamaral
joaopamaral requested a review from Khrol January 16, 2025 18:09

@Khrol Khrol left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is good but I don't like that we don't load all the data and this will be un-known for the end user. Noone will read these warnings.

@joaopamaral
joaopamaral requested a review from Khrol January 17, 2025 16:08
@joaopamaral
joaopamaral merged commit 823d4b7 into master Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants