Agentic UI: Keep the native window controls inside the frame on Windows and Linux - #4499
Open
bcotrim wants to merge 9 commits into
Open
Agentic UI: Keep the native window controls inside the frame on Windows and Linux#4499bcotrim wants to merge 9 commits into
bcotrim wants to merge 9 commits into
Conversation
…p the modal close buttons
bcotrim
marked this pull request as ready for review
August 10, 2026 21:26
bcotrim
requested review from
katinthehatsite,
nightnei,
sejas and
shaunandrews
August 10, 2026 21:26
Collaborator
📊 Performance Test ResultsComparing 1cb6ac1 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
Contributor
Contributor
Author
|
@shaunandrews added the fix and updated the images in the PR description! |
katinthehatsite
left a comment
Contributor
There was a problem hiding this comment.
It looks good on macOS and I did not see any regressions but I have not tested on Windows or Linux.
I think we could merge once we have another set of eyes to test these platforms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related issues
How AI was used in this PR
Claude mapped the frame/overlay code paths, implemented the change, and measured the resulting geometry and surface colors in the running UI. I reviewed the diff and the reasoning.
Proposed Changes
trafficLightPosition.Testing Instructions
macOS regression check: the frame keeps its 12px inset and rounded corners, and the traffic lights are unchanged.
One thing worth a close look: with the preview closed in dark mode, the surface behind the controls is
rgb(30,30,30)while the overlay paintsrgb(36,36,36). Expected to be imperceptible; if it reads as a seam, the fix is per-routesetTitleBarOverlay()colours.Pre-merge Checklist