Agentic UI: Keep app-wide toasts above the composer when the sidebar is closed - #4497
Conversation
📊 Performance Test ResultsComparing 59eaf99 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
katinthehatsite
left a comment
There was a problem hiding this comment.
The issue is fixed for me in this PR but I am wondering if we can find a better position in general for these toasts when the sidebar is closed. To me, it feels like it obscures the chat field and gets into the content flow. Some possible options:
- top of the main panel, below the header OR
- top right of the viewport
What do you think?
If we want to proceed fast, we can merge this to fix an immediate bug but I think it might be a good approach to revise the position in general
I don't have a strong opinion, but maybe the top right of the composer view would be good.
Yes, if this fixed the bug and we agree it's an improvement overall let's ship it for the beta while we discuss a better alternative. Thanks for the review and for bringing up the discussion! |
This sounds good to me 👍 I will approve the changes now and we can iterate on the placement later |
|
In my experience, I don't get many toasts while I'm focused in the chat with the sidebar off. And if I do, I think its helpful to see them near where my focus is—the chat composer, without obscuring my writing. They seem rare in this scenario, They go away on their own. And they are easily dismissible. Lets see what users say. |
Related issues
How AI was used in this PR
AI traced the root cause, wrote the fix and the test, and verified the resulting geometry live in
studio ui(light + dark). I reviewed the diff.Proposed Changes
Testing Instructions
Pre-merge Checklist