[PAY-3156] Fix Rewards Claiming Analytics - #9024
Merged
Merged
Conversation
added 11 commits
July 1, 2024 16:18
🦋 Changeset detectedLatest commit: 745e7e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rickyrombo
changed the title
commented
Jul 2, 2024
Collaborator
|
Preview this change https://demo.audius.co/mjp-challenge-analytics |
schottra
approved these changes
Jul 3, 2024
| const isResponseError = (error: Error): error is ResponseError => | ||
| 'response' in error && error.response instanceof Response | ||
| export const isResponseError = (error: unknown): error is ResponseError => | ||
| error instanceof Error && error.name === 'ResponseError' |
Contributor
There was a problem hiding this comment.
Responded about this in Slack, but I'm wondering if we shouldn't just update our compilation target? instanceof is a pretty useful/common pattern for checking things and since we don't have access to the internals of third-party code, it would be nice to maintain the ability to use it.
added 2 commits
July 8, 2024 16:39
rickyrombo
enabled auto-merge (squash)
July 8, 2024 21:43
commented
Jul 8, 2024
Collaborator
|
Preview this change https://demo.audius.co/mjp-challenge-analytics |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PAY-3156
Changes the analytics for Rewards and adds support for them in the SDK flow. Removes non-SDK flow.
How Has This Been Tested?
Tested locally