Skip to content

Fix type errors from last SDK update - #12641

Merged
rickyrombo merged 3 commits into
mainfrom
mjp-fix-sdk-typeerrors
Aug 2, 2025
Merged

Fix type errors from last SDK update#12641
rickyrombo merged 3 commits into
mainfrom
mjp-fix-sdk-typeerrors

Conversation

@rickyrombo

@rickyrombo rickyrombo commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

Fixes type errors issues introduced in #12635

changeset-bot

ghost commented Aug 1, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b088c31

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ghost ghost added the size/M label Aug 1, 2025
rickyrombo
rickyrombo commented Aug 1, 2025
View reviewed changes
Comment thread packages/sdk/src/sdk/services/EntityManager/EntityManagerClient.ts
!userId ||
!entityType ||
// 0 is a valid entityId for some actions
(!entityId && entityId !== 0n) ||

ghost Aug 1, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @raymondjacobson you gotta use BigInt(0) for now until we target newer

ghost Aug 1, 2025 •
edited by rickyrombo
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also... I'm pretty sure this check will never be false? 0x00000000000000000000000000000000 would be 0, right? Would missing bytes be null or undefined?

@ghost
ghost merged commit da813d6 into main Aug 2, 2025
@ghost
ghost deleted the mjp-fix-sdk-typeerrors branch August 2, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondjacobson raymondjacobson raymondjacobson approved these changes

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rickyrombo @raymondjacobson