Repository navigation
packaging: remove repository-only namespaces from the wheel - #171
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
dataand all current runtime packages unchanged and explicitly installed pending focused migrations and a separate package-data audit.Description
pyproject.toml; the exact configured package names removed aredoc,doc.blog,doc.integrations,env,env.config,env.docker,env.docker.cu130,env.docker.cu130.scripts,log,log.scheduler,scripts,test, andtest.kdnand the explicit packages list was updated to preserve only transitional runtime packages.test/test_repository_governance.pyandtest/test_wheel_install.pyto (a) exclude repository-only prefixes via the named constantREPOSITORY_ONLY_PACKAGE_PREFIXES, (b) assert repository-only names and descendants are not present in the setuptoolspackagesconfiguration, and (c) assert forbidden top-level namespaces are absent from built wheels (with CPythonteststdlib collision handled explicitly).doc/architecture/package-architecture-rfc.mdanddoc/package_migration_phase_a.mdand clarified thatdataremains installed pending a separate consumer/package-data audit.pyproject.toml,test/test_repository_governance.py,test/test_wheel_install.py,doc/architecture/package-architecture-rfc.md, anddoc/package_migration_phase_a.md.UI,cacheroute,cacheroute_compat,client,core,data,instance,kdn_server,model,proxy,scheduler,store, andutil, and the forbidden top-level namespaces aredoc,env,log,scripts, andtest.datafiles were changed.Testing
python3 -m pip install -e . --no-build-isolation --no-depsand ran byte-compilation withpython3 -m compileallon the listed packages successfully.test/test_repository_governance.pypassed (7 tests),test/test_namespace_layout.pyran with 4 passed and 1 environment-limited failure (collection/import blocked due to missing declared dependencyaiohttp),test/test_wheel_install.py(non-network) produced 3 passed and 1 deselected, andtest/kdnpassed (256 tests); several test collections were blocked because the validation host could not fetch declared runtime dependencies (aiohttp,fastapi) from the package index.python3 -m pip wheel . --no-deps --no-build-isolation -w distproducingcacheroute-0.1.9-py3-none-any.whl(512,026 bytes), and an independent wheel-member audit confirmed the exact allowed top-level packages, absence of repository-only namespaces, presence of required runtime package-data (UI assets, instance dashboard assets, model config, proxy metrics), and exclusion of generated TTFT logs.cacheroute,cacheroute.compat,cacheroute.observability,cacheroute_compat).CACHEROUTE_RUN_NETWORK_TESTS=1) andpython3 -m build --no-isolationwere NOT RUN / blocked due to package-index access and the missingbuildmodule in the validation environment; these must be executed in CI or an environment with network access before merge.Closes #170
Refs #159
Refs #157
Codex Task