Skip to content

fix(platform): keep the Satori heartbeat and reconnect delays from being disabled by a cleared field #10248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Soulter merged 2 commits into from
Sep 27, 2026
Merged

fix(platform): keep the Satori heartbeat and reconnect delays from being disabled by a cleared field #10248

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7e19db
fix(satori): keep a positive floor on the heartbeat and reconnect int…
marazer180 Sep 27, 2026
27ffc62
Delete tests/test_satori_adapter_heartbeat_floor.py
Soulter Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions astrbot/core/platform/sources/satori/satori_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
register_platform_adapter,
)
from astrbot.core.platform.astr_message_event import MessageSession
from astrbot.core.utils.config_number import coerce_int_config
from astrbot.core.utils.media_utils import MediaResolver

if TYPE_CHECKING:
Expand Down Expand Up @@ -57,8 +58,20 @@ def __init__(
"ws://localhost:5140/satori/v1/events",
)
self.auto_reconnect = self.config.get("satori_auto_reconnect", True)
self.heartbeat_interval = self.config.get("satori_heartbeat_interval", 10)
self.reconnect_delay = self.config.get("satori_reconnect_delay", 5)
self.heartbeat_interval = coerce_int_config(
self.config.get("satori_heartbeat_interval", 10),
default=10,
min_value=1,
field_name="satori_heartbeat_interval",
source="Satori config",
Comment on lines +61 to +66

@sourcery-ai sourcery-ai Bot Sep 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): coerce_int_config raises OverflowError when the configuration value is positive or negative infinity, because it calls int(value) without catching OverflowError; the Satori adapter then fails during construction instead of falling back to its default.

Triggers: When a hand-edited JSON configuration contains Infinity, -Infinity, or a numeric value large enough for Python's JSON parser to produce an infinite float.

Suggested fix: Catch OverflowError alongside TypeError and ValueError in coerce_int_config, or reject non-finite numeric values before conversion.

)
self.reconnect_delay = coerce_int_config(
self.config.get("satori_reconnect_delay", 5),
default=5,
min_value=1,
field_name="satori_reconnect_delay",
source="Satori config",
)

self.metadata = PlatformMetadata(
name="satori",
Expand Down
Loading