Remove the 1.x projects that 2.0 does not build - #158
Merged
Merged
Conversation
AustinHarris.JsonRpc.Client, AustinHarris.JsonRpc.AspNet, JsonRpcTest and TestClient were .NET Framework 4.0 packages.config projects outside the solution. Nothing built them, CI never compiled them, and their pinned Newtonsoft.Json 6.0.3 and 12.0.3 and Rx-Main 1.0 carried the repository's four open security alerts. Their source stays in the history before 2.0; the README and CHANGELOG say so.
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AustinHarris.JsonRpc.Client,AustinHarris.JsonRpc.AspNet,JsonRpcTestandTestClientwere .NET Framework 4.0packages.configprojects outside the solution. Nothing built them and CI never compiled them, so a dependency bump in them cannot be verified and changes nothing that ships. Their pinned Newtonsoft.Json 6.0.3 and 12.0.3 and Rx-Main 1.0 carried the repository's four open Dependabot alerts.This removes the four folders, the same treatment the Windows Phone 7 client got in #155. The source stays in the git history before 2.0 and the 1.x packages stay on NuGet. The README's Building section and the CHANGELOG's Removed list say so; the Classic ASP.NET section still names the 1.x
AustinHarris.JsonRpc.AspNetpackage as not part of 2.0, which remains true.Supersedes #156 and #157, which bumped Newtonsoft.Json in two of the four projects.