fix(mobile): swallow blank-space terminal long presses - #471
Merged
Merged
Conversation
Owner
|
Merged, thanks @DodgyBadger! This ships in 1.32.1. It is exactly the fix we sketched in #360: arm the focus and compat-mouse guards before asking whether the press landed on text, so a hold on blank space gets swallowed the same way a hold on a word already was. Small, and the regression test really does fail on master, which is what made this an easy merge with no changes on my side. Two behaviour edges come with treating every 350 ms hold as a long press, both intended: a slow press on blank space no longer extends an existing selection (a quick tap still does), and a slow press on the blank tail of the prompt row no longer opens the keyboard. If either feels wrong on your phone, tell me and we tune it. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
touchendpath suppresses Android Chrome's native behavior.Fixes #360
Testing
npm test -- test/terminal-touch-tap.test.ts(58 passed)npm test(7,828 passed, 12 skipped)npm run check:frontend-syntaxnpm run check:public-assets