Skip to content

Added Danish translation - #16

Merged
tim-hub merged 1 commit into
Antioch-Tech:masterfrom
Nicolai9852:master
Sep 14, 2024
Merged

Added Danish translation#16
tim-hub merged 1 commit into
Antioch-Tech:masterfrom
Nicolai9852:master

Conversation

@Nicolai9852

@Nicolai9852 Nicolai9852 commented Sep 10, 2024

Copy link
Copy Markdown

I have created the Danish book names and abbreviations

Before merge - will it work if an abbreviation with startNumber 0 has the same as startnumer 1
This is because the abbreviations are somewhat the same between the Gospel of John and Letters of John

Also, the Torah (Genesis, Exodus, Lev, Num, and Deut) use a number and the title "Mosebog" in Danish (Mosebog means "Book of Moses")
Therefore, they are all named "Mosebog" and use a startNumber

@tim-hub

tim-hub commented Sep 10, 2024

Copy link
Copy Markdown
Collaborator

@Nicolai9852

There is a duplication in the json.

Mos is duplicated among other books

@tim-hub

tim-hub commented Sep 10, 2024

Copy link
Copy Markdown
Collaborator

@Nicolai9852

There is a duplication in the json.

Mos is duplicated among other books

Never mind, I got you, the first 5 books.
Let me find time to fix the test to cover this case.

@tim-hub
tim-hub merged commit a170906 into Antioch-Tech:master Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants